Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932254AbdIFNqN (ORCPT ); Wed, 6 Sep 2017 09:46:13 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:46530 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932100AbdIFNqI (ORCPT ); Wed, 6 Sep 2017 09:46:08 -0400 Date: Wed, 6 Sep 2017 06:46:07 -0700 From: Christoph Hellwig To: Javier =?iso-8859-1?Q?Gonz=E1lez?= Cc: mb@lightnvm.io, axboe@fb.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Javier =?iso-8859-1?Q?Gonz=E1lez?= , Matias =?iso-8859-1?Q?Bj=F8rling?= Subject: Re: [PATCH 01/18] lightnvm: pblk: improve naming for internal req. Message-ID: <20170906134607.GC3960@infradead.org> References: <1504695071-25928-1-git-send-email-javier@cnexlabs.com> <1504695071-25928-2-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504695071-25928-2-git-send-email-javier@cnexlabs.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 312 Lines: 14 > -#define ERASE 2 /* READ = 0, WRITE = 1 */ > +/* READ = 0, WRITE (user) = 1 */ > +#define ERASE 2 > +#define WRITE_INT 3 /* Internal write. Not through write buffer */ enum { PBLK_READ, PBLK_WRITE, PBLK_ERASE, PBLK_WRITE, }; please. Don't abuse and overload the messy READ/WRITE macros in any new code.