Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932408AbdIFOBt (ORCPT ); Wed, 6 Sep 2017 10:01:49 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38476 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754872AbdIFOBr (ORCPT ); Wed, 6 Sep 2017 10:01:47 -0400 X-Google-Smtp-Source: ADKCNb5IZs1OvjD4H/slaMucqIocjIzi0gspmAewcAcODhmiFLFB7W5ChbDh4e6l5X7g1yPt1O6DSQ== From: =?utf-8?Q?Javier_Gonz=C3=A1lez?= Message-Id: <7C9D69B3-96AC-4038-9395-FAA618B88EE4@lightnvm.io> Content-Type: multipart/signed; boundary="Apple-Mail=_B7A1EF50-077B-4E7E-A7A5-0A3C33AA8178"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH 01/18] lightnvm: pblk: improve naming for internal req. Date: Wed, 6 Sep 2017 16:01:43 +0200 In-Reply-To: <20170906134607.GC3960@infradead.org> Cc: =?utf-8?Q?Matias_Bj=C3=B8rling?= , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?Q?Matias_Bj=C3=B8rling?= To: Christoph Hellwig References: <1504695071-25928-1-git-send-email-javier@cnexlabs.com> <1504695071-25928-2-git-send-email-javier@cnexlabs.com> <20170906134607.GC3960@infradead.org> X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1673 Lines: 53 --Apple-Mail=_B7A1EF50-077B-4E7E-A7A5-0A3C33AA8178 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > On 6 Sep 2017, at 15.46, Christoph Hellwig wrote: > >> -#define ERASE 2 /* READ = 0, WRITE = 1 */ >> +/* READ = 0, WRITE (user) = 1 */ >> +#define ERASE 2 >> +#define WRITE_INT 3 /* Internal write. Not through write buffer */ > > enum { > PBLK_READ, > PBLK_WRITE, > PBLK_ERASE, > PBLK_WRITE, > }; > > please. Don't abuse and overload the messy READ/WRITE macros in any > new code. Ok. I'll resend. Javier --Apple-Mail=_B7A1EF50-077B-4E7E-A7A5-0A3C33AA8178 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJZr//HAAoJEGMfBTt1mRjK1OIP/jqBXgLloo3kjoia7MsaHDn4 dNMJ/aeOK/OWtM2mgeA824jbMzZXuBCS4/j6h9VqFRTbeRivINFV39XX/E5zHlM5 hRFhyUG5Hqp3upVHXE5WwAh6LLeyonxWkqLCST6ilOQF2s/6gVg+ATXGCwYWKgWA GQvF2MBXraE7AF5Ltjhn1w2JaOrKOPbHh1bChekAttbmWi4mon3viGPLjdigtDdx XIWH3p/Tw8hlQluxNc7gajS8D7z/hRh3b2Z5H+3RGYOQ0DiI9P431CZjpLAs6fXJ aSnL1BVhYfdtLI4o67gOeNldz6K40pDD+93h/0zd/kpsGOMVNbrFO+1+IWPCucm/ nUCE8QXj/qNJdo/oxDiCLwaJ1QiJShlKtO0V2UVWIQy0lsO3tnAXzRijJ8frIe84 +gavowgIcxdwiISofQk21fGF2FT3Ptaz7OsksI7MTeN7MCbxk58rjJN2f4EhINNf plc1yR2LBlt2daJiFbfxBjJqYA9uifmOoBxZ/ROuRg5Zd6zM+g42AVR/Dc4B1YhS UNIcpfdIwV5b+M3MEoZPdAaYnLAsnGgBezx5yvlw5n+Xcn/RSC4h6FmcXI/JZee6 nBE2BfTw9GR2fD4i9DmrfYhzE8wCt7Zn1Jet6S+24ACvUVXczrQytPDl7i1TBJsz 7rl5TR5KYsGTqsYbJYAb =78AZ -----END PGP SIGNATURE----- --Apple-Mail=_B7A1EF50-077B-4E7E-A7A5-0A3C33AA8178--