Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932476AbdIFOS6 (ORCPT ); Wed, 6 Sep 2017 10:18:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39490 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932280AbdIFOSz (ORCPT ); Wed, 6 Sep 2017 10:18:55 -0400 Date: Wed, 6 Sep 2017 16:18:55 +0200 From: Greg KH To: "Li, Zhenhua" Cc: "jslaby@suse.com" , "mingo@kernel.org" , "andriy.shevchenko@linux.intel.com" , "mail@maciej.szmigiero.name" , "mgorman@suse.de" , "safinaskar@mail.ru" , "mhocko@suse.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/1] drivers/tty: check for null pointer Message-ID: <20170906141855.GA17134@kroah.com> References: <20170906133811.8072-1-lizhenhuajiyang@163.com> <20170906134705.GA12073@kroah.com> <151d3a06.73a0.15e577b217f.Coremail.lizhenhuajiyang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <151d3a06.73a0.15e577b217f.Coremail.lizhenhuajiyang@163.com> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 968 Lines: 33 A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Sep 06, 2017 at 09:57:20PM +0800, Li, Zhenhua wrote: > when I tried to boot linux on a system with virtual bios and vortual keyboard, > it crashes. What exact "virtual bios and keyboard" are you referring to here? QEMU? Something else? > The root cause is the bios does not initialize devices correctly. How does the bios come into play here? It should not matter, it should only be a kernel driver that can set this value. > did not track what drivers called this function. What was the full oops message? That should show the problem. And by just rejecting the call here, you are probably just postponing the real fix from happening, we should resolve that. thanks, greg k-h