Subject: Re: [PATCH V13 2/4] powerpc/vphn: Improve recognition of PRRN/VPHN
To: Michael Bringmann <mwb@linux.vnet.ibm.com>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: Michael Ellerman <mpe@ellerman.id.au>,
        John Allen <jallen@linux.vnet.ibm.com>
References: <067ca4f6-3181-6c6d-32cf-7164fe2c715d@linux.vnet.ibm.com>
From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Date: Wed, 6 Sep 2017 09:24:10 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <067ca4f6-3181-6c6d-32cf-7164fe2c715d@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Message-Id: <71a117da-fb2d-7e1e-2609-78dfb920d103@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1481
Lines: 47


On 09/01/2017 10:48 AM, Michael Bringmann wrote:
> powerpc/vphn: On Power systems with shared configurations of CPUs
> and memory, there are some issues with the association of additional
> CPUs and memory to nodes when hot-adding resources.  This patch
> updates the initialization checks to independently recognize PRRN
> or VPHN support.
> 
> Signed-off-by: Michael Bringmann <mwb@linux.vnet.ibm.com>
> ---
> Changes in V13:
>   -- Split patch to improve review
> ---
>  arch/powerpc/mm/numa.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index 312f6ee..c08d736 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -1543,7 +1543,8 @@ int start_topology_update(void)
>  			rc = of_reconfig_notifier_register(&dt_update_nb);
>  #endif
>  		}
> -	} else if (firmware_has_feature(FW_FEATURE_VPHN) &&
> +	}
> +	if (firmware_has_feature(FW_FEATURE_VPHN) &&
>  		   lppaca_shared_proc(get_lppaca())) {
>  		if (!vphn_enabled) {
>  			vphn_enabled = 1;

In patch 1/4, you removed the setting of prrn_enabled and vphn_enabled
to 0. It seems like that update would be part of this patch.

-Nathan

> @@ -1568,7 +1569,8 @@ int stop_topology_update(void)
>  #ifdef CONFIG_SMP
>  		rc = of_reconfig_notifier_unregister(&dt_update_nb);
>  #endif
> -	} else if (vphn_enabled) {
> +	}
> +	if (vphn_enabled) {
>  		vphn_enabled = 0;>  		rc = del_timer_sync(&topology_timer);
>  	}
>