Date: Wed, 6 Sep 2017 07:33:20 -0700
From: Tejun Heo <tj@kernel.org>
To: zijun_hu <zijun_hu@zoho.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, jiangshanlai@gmail.com,
        linux-kernel@vger.kernel.org, zijun_hu@htc.com
Subject: Re: [PATCH 1/1] workqueue: use type int instead of bool to index
 array
Message-ID: <20170906143320.GK1774378@devbig577.frc2.facebook.com>
References: <59AF6CB6.4090609@zoho.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <59AF6CB6.4090609@zoho.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 392
Lines: 17

Hello,

On Wed, Sep 06, 2017 at 11:34:14AM +0800, zijun_hu wrote:
> From: zijun_hu <zijun_hu@htc.com>
> 
> type bool is used to index three arrays in alloc_and_link_pwqs()
> it doesn't look like conventional.
> 
> it is fixed by using type int to index the relevant arrays.

bool is a uint type which can be either 0 or 1.  I don't see what the
benefit of this patch is.q

Thanks.

-- 
tejun