Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755167AbdIFPzd (ORCPT ); Wed, 6 Sep 2017 11:55:33 -0400 Received: from resqmta-ch2-01v.sys.comcast.net ([69.252.207.33]:46454 "EHLO resqmta-ch2-01v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753492AbdIFPzc (ORCPT ); Wed, 6 Sep 2017 11:55:32 -0400 Date: Wed, 6 Sep 2017 10:55:30 -0500 (CDT) From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: Vlastimil Babka cc: js1304@gmail.com, Andrew Morton , Pekka Enberg , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mel Gorman , Michal Hocko , Joonsoo Kim Subject: Re: [PATCH 2/2] mm/slub: don't use reserved memory for optimistic try In-Reply-To: Message-ID: References: <1504672666-19682-1-git-send-email-iamjoonsoo.kim@lge.com> <1504672666-19682-2-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfHqnAR7gcQvCyIHQm2bgAwveDCA39qNuDlJ04CYkxiDJkRrJULSMBjO/s+Tz3EEoXZH49Y0jVzXUwosvpUETJbg5UlnX6v+2X2uytNskX2CBuMa/ijE1 XUHwECh+4Znqr3mxzOhNM9vw+nKJrnAIhpM3ZhG5wISQkUEeNmC8n5voXOpMtslDQxTPYdFxD3A/NZaEyxOhZbFfNGQUkn6YsZPIxjHSIRRlOhAlnGJQmGtg 6GzUfO5Kl5d8KrrXjWilZghYFiPQg6qo67wgVBYnCT0ChTUR0CDhio1Qjo7dr9W2S9yu/lcYFvCOJbOCXdhCQQZXIbhZ+e9xPfDcMNLN1P8WRcnXpOMCmLtX wv1ebzuLxcFGtkDjHFciuu1ZtqScn6Tz34lL7TQrWkl+0lGMpBLDizfXl3SNq1j6Qjwya2mbRrmmBW6A0zehYtcCLglKbQ7bFXqpHjZ6uRmipUQNgtk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 259 Lines: 8 On Wed, 6 Sep 2017, Vlastimil Babka wrote: > I think it's wasteful to do a function call for this, inline definition > in header would be better (gfp_pfmemalloc_allowed() is different as it > relies on a rather heavyweight __gfp_pfmemalloc_flags(). Right.