Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751682AbdIFR7Z (ORCPT ); Wed, 6 Sep 2017 13:59:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:56637 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750739AbdIFR7X (ORCPT ); Wed, 6 Sep 2017 13:59:23 -0400 Date: Wed, 6 Sep 2017 19:59:19 +0200 From: Michal Hocko To: Roman Gushchin Cc: linux-mm@kvack.org, Vladimir Davydov , Johannes Weiner , Tetsuo Handa , David Rientjes , Andrew Morton , Tejun Heo , kernel-team@fb.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v7 5/5] mm, oom: cgroup v2 mount option to disable cgroup-aware OOM killer Message-ID: <20170906175919.e5hshqjjto2wb63b@dhcp22.suse.cz> References: <20170904142108.7165-1-guro@fb.com> <20170904142108.7165-6-guro@fb.com> <20170905134412.qdvqcfhvbdzmarna@dhcp22.suse.cz> <20170905143021.GA28599@castle.dhcp.TheFacebook.com> <20170905151251.luh4wogjd3msfqgf@dhcp22.suse.cz> <20170905191609.GA19687@castle.dhcp.TheFacebook.com> <20170906084242.l4rcx6n3hdzxvil6@dhcp22.suse.cz> <20170906174043.GA12579@castle.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170906174043.GA12579@castle.DHCP.thefacebook.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2331 Lines: 74 On Wed 06-09-17 18:40:43, Roman Gushchin wrote: [...] > >From f6e2339926a07500834d86548f3f116af7335d71 Mon Sep 17 00:00:00 2001 > From: Roman Gushchin > Date: Wed, 6 Sep 2017 17:43:44 +0100 > Subject: [PATCH] mm, oom: first step towards oom_kill_allocating_task > deprecation > > The oom_kill_allocating_task sysctl which causes the OOM killer > to simple kill the allocating task is useless. Killing the random useless is quite strong ;) I would say dubious. > task is not the best idea. > > Nobody likes it, and hopefully nobody uses it. > We want to completely deprecate it at some point. > > To make a first step towards deprecation, let's warn potential > users about deprecation plans. > > Signed-off-by: Roman Gushchin > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Johannes Weiner > Cc: David Rientjes > Cc: Vladimir Davydov > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org Other than that Acked-by: Michal Hocko > --- > kernel/sysctl.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 655686d546cb..9158f1980584 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -220,6 +220,17 @@ static int sysrq_sysctl_handler(struct ctl_table *table, int write, > > #endif > > +static int proc_oom_kill_allocating_tasks(struct ctl_table *table, int write, > + void __user *buffer, size_t *lenp, > + loff_t *ppos) > +{ > + pr_warn_once("The oom_kill_allocating_task sysctl will be deprecated.\n" > + "If you're using it, please, report to " > + "linux-mm@kvack.kernel.org.\n"); > + > + return proc_dointvec(table, write, buffer, lenp, ppos); > +} > + > static struct ctl_table kern_table[]; > static struct ctl_table vm_table[]; > static struct ctl_table fs_table[]; > @@ -1235,7 +1246,7 @@ static struct ctl_table vm_table[] = { > .data = &sysctl_oom_kill_allocating_task, > .maxlen = sizeof(sysctl_oom_kill_allocating_task), > .mode = 0644, > - .proc_handler = proc_dointvec, > + .proc_handler = proc_oom_kill_allocating_tasks, > }, > { > .procname = "oom_dump_tasks", > -- > 2.13.5 -- Michal Hocko SUSE Labs