Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753199AbdIFVTP (ORCPT ); Wed, 6 Sep 2017 17:19:15 -0400 Received: from twin.jikos.cz ([89.185.236.188]:56932 "EHLO twin.jikos.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753131AbdIFVTO (ORCPT ); Wed, 6 Sep 2017 17:19:14 -0400 Date: Wed, 6 Sep 2017 23:16:02 +0200 (CEST) From: Jiri Kosina X-X-Sender: jikos@twin.jikos.cz To: Linus Torvalds cc: Ingo Molnar , Linux Kernel Mailing List , Thomas Gleixner , "H. Peter Anvin" , Peter Zijlstra , Andrew Morton , Andy Lutomirski , Borislav Petkov Subject: Re: [GIT PULL] x86/mm changes for v4.14: PCID support, 5-level paging support, Secure Memory Encryption support In-Reply-To: Message-ID: References: <20170904093158.k6pg3ytcbotjlhv5@gmail.com> <20170905214046.ishenhbj7jrtoufc@gmail.com> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 36 On Wed, 6 Sep 2017, Jiri Kosina wrote: > This is a "me too", observed on my Lenovo thinkpad x270 (so it's not > specific to that XPS 13 system at all). > > The symptom I observe is that an attempt to resume from hibernation > proceeds up to reading 100% of the hibernation image, and then reboot > happens (IOW looks like triple fault). > > nopcid cures it, I haven't tried to revert 10af6235e0d3 yet, but looks > like it's the same thing. [ reposting the information again with LKML re-introduced to CC ] As suggested by Andy off-list, I tested with this change to always force ASID 0 diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 5ca71d1..c3b0811 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -35,7 +35,7 @@ static void choose_new_asid(struct mm_struct *next, u64 next_tlb_gen, { u16 asid; - if (!static_cpu_has(X86_FEATURE_PCID)) { + if (true || !static_cpu_has(X86_FEATURE_PCID)) { *new_asid = 0; *need_flush = true; return; and that fixes the issue on my system. -- Jiri Kosina SUSE Labs