MIME-Version: 1.0
In-Reply-To: <20170906213243.gyttos3s64ckoswp@mwanda>
References: <1504732426-9765-1-git-send-email-srishtishar@gmail.com> <20170906213243.gyttos3s64ckoswp@mwanda>
From: Srishti Sharma <srishtishar@gmail.com>
Date: Thu, 7 Sep 2017 03:12:25 +0530
Message-ID: <CAB3L5owK3M3fZJwXAiuSY9bggxVpn2x=pZ_MfBQiGfW00G7Eaw@mail.gmail.com>
Subject: Re: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, devel@driverdev.osuosl.org,
        outreachy-kernel@googlegroups.com,
        driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1039
Lines: 26

On Thu, Sep 7, 2017 at 3:02 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Always compile your patches.
>
>   CC [M]  drivers/staging/ccree/ssi_cipher.o
> drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’:
> drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable ‘inflight_counter’ [-Wunused-variable]
>   u32 inflight_counter;
>       ^~~~~~~~~~~~~~~~
>
> You need to delete the declaration as well.
>
> Don't be in a rush to resend patches.  I normally write them then let
> them sit in my outbox overnight and send them in the morning.  The extra
> delay helps me to calm down a bit and focus better.  Even though I've
> sent thousands of patches, it sometimes still stresses me out.  It's
> like you're disagreeing with the original author and the reviewers are
> disagreeing with you and everyone's trying to be nice about it but
> patches are fundamentally points of disagreement and that's stress.
>
> regards,
> dan carpenter
>
 Thanks , I'll be more careful !

 Regards,
 Srishti