Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753591AbdIFW52 convert rfc822-to-8bit (ORCPT ); Wed, 6 Sep 2017 18:57:28 -0400 Received: from tyo161.gate.nec.co.jp ([114.179.232.161]:43309 "EHLO tyo161.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbdIFW50 (ORCPT ); Wed, 6 Sep 2017 18:57:26 -0400 X-Greylist: delayed 567 seconds by postgrey-1.27 at vger.kernel.org; Wed, 06 Sep 2017 18:57:26 EDT From: Kosuke Tatsukawa To: Jay Vosburgh , Veaceslav Falico , Andy Gospodarek CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Reinis Rozitis Subject: Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode Thread-Topic: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode Thread-Index: AdMnYdsPISfgevJWRPag1aiagu4p1A== Date: Wed, 6 Sep 2017 22:45:36 +0000 Message-ID: <17EC94B0A072C34B8DCF0D30AD16044A02985C94@BPXM09GP.gisp.nec.co.jp> In-Reply-To: <17EC94B0A072C34B8DCF0D30AD16044A0296FEF5@BPXM09GP.gisp.nec.co.jp> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.34.125.78] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2292 Lines: 55 Reinis Rozitis reported that tlb_dynamic_lb was still 0 in balance-alb mode even when using linux-4.12.10 kernels, which includes this patch. It turned out that my previous patch only fixed the case when balance-alb mode was specified as bonding module parameter, and not when balance-alb mode was set using /sys/class/net/*/bonding/mode (the most common usage). In the latter case, tlb_dynamic_lb was set up according to the default mode of the bonding interface, which happens to be balance-rr. I'll send another patch to address this case. In the meantime, a workaround for this issue is to specify balance-tlb mode as a module parameter for bonding. This will change the value of tlb_balance_lb to 1, and make balance-alb work like pre-4.12 kernels. Best regards. > balance-alb mode used to have transmit dynamic load balancing feature > enabled by default. However, transmit dynamic load balancing no longer > works in balance-alb after commit 8b426dc54cf4 ("bonding: remove > hardcoded value"). > > Both balance-tlb and balance-alb use the function bond_do_alb_xmit() to > send packets. This function uses the parameter tlb_dynamic_lb. > tlb_dynamic_lb used to have the default value of 1 for balance-alb, but > now the value is set to 0 except in balance-tlb. > > Re-enable transmit dyanmic load balancing by initializing tlb_dynamic_lb > for balance-alb similar to balance-tlb. > > Signed-off-by: Kosuke Tatsukawa > Cc: stable@vger.kernel.org > --- > drivers/net/bonding/bond_main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index 14ff622..181839d 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -4596,7 +4596,7 @@ static int bond_check_params(struct bond_params *params) > } > ad_user_port_key = valptr->value; > > - if (bond_mode == BOND_MODE_TLB) { > + if ((bond_mode == BOND_MODE_TLB) || (bond_mode == BOND_MODE_ALB)) { > bond_opt_initstr(&newval, "default"); > valptr = bond_opt_parse(bond_opt_get(BOND_OPT_TLB_DYNAMIC_LB), > &newval); --- Kosuke TATSUKAWA | 1st Platform Software Division | NEC Solution Innovators | tatsu@ab.jp.nec.com