Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753406AbdIGAsP (ORCPT ); Wed, 6 Sep 2017 20:48:15 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33017 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752327AbdIGAsO (ORCPT ); Wed, 6 Sep 2017 20:48:14 -0400 X-Google-Smtp-Source: ADKCNb4q6KV7w4tBOR0oZSO4oLESmkq76b8VT8IamEWUNtiMLzLZx5r+p6DVYLo6N95kq+a7WYsEww== Date: Thu, 7 Sep 2017 09:45:22 +0900 From: Sergey Senozhatsky To: Helge Deller Cc: linux-kernel@vger.kernel.org, Sergey Senozhatsky , Petr Mladek , Andrew Morton Subject: Re: [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages Message-ID: <20170907004522.GA3885@jagdpanzerIV.localdomain> References: <1504729681-3504-1-git-send-email-deller@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504729681-3504-1-git-send-email-deller@gmx.de> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 699 Lines: 21 On (09/06/17 22:27), Helge Deller wrote: > This patch series fixes the wrong usages of the %pF and %pS printk format > specifiers throughout the kernel code. > > Both specifiers have the same result on most architectures. But on ia64, ppc64 > and parisc64 architectures the %pF specifier does an extra conversion because > there function pointers are actually function descriptors. hm... can we fix it in lib/vsprintf.c instead? a) the patch set has "there is no problem on platform A, but still let's just change it" which is probably fine. but b) you tweak/fix the currently existing users, OK. but there, most likely, will be new users that will require fixes in the future. -ss