Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753167AbdIGC1s (ORCPT ); Wed, 6 Sep 2017 22:27:48 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:9116 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752146AbdIGC1r (ORCPT ); Wed, 6 Sep 2017 22:27:47 -0400 X-IronPort-AV: E=Sophos;i="5.42,356,1500912000"; d="scan'208";a="25355011" Subject: Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for sanity check cleanup To: Baoquan He References: <1503890438-27840-1-git-send-email-douly.fnst@cn.fujitsu.com> <1503890438-27840-7-git-send-email-douly.fnst@cn.fujitsu.com> <20170906042514.GF30906@x1> <20170906052614.GG30906@x1> <96aae229-04d4-fc31-9646-3ca7c029365a@cn.fujitsu.com> <20170906080304.GJ30906@x1> CC: , , , , , , , , From: Dou Liyang Message-ID: <1d29b070-2922-2ac7-febf-491bd49f542f@cn.fujitsu.com> Date: Thu, 7 Sep 2017 10:27:40 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170906080304.GJ30906@x1> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.106] X-yoursite-MailScanner-ID: 9BADF4725575.AAC15 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 899 Lines: 33 At 09/06/2017 04:03 PM, Baoquan He wrote: > On 09/06/17 at 01:41pm, Dou Liyang wrote: >> Hi Baoquan, >> >> At 09/06/2017 01:26 PM, Baoquan He wrote: >> [...] >> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c >> index 4f63afc..9f8479c 100644 >> --- a/arch/x86/kernel/smpboot.c >> +++ b/arch/x86/kernel/smpboot.c >> @@ -1260,8 +1260,10 @@ static void __init smp_get_logical_apicid(void) >> } >> >> /* >> - * Prepare for SMP bootup. The MP table or ACPI has been read >> - * earlier. Just do some sanity checking here and enable APIC mode. >> + * Prepare for SMP bootup. >> + * >> + * @max_cpus: configured maximum number of CPUs >> + * It don't be used, but other arch also have this hook, so keep it. How about: @max_cpus: configured maximum number of CPUs It is a legacy parameter for common interface support > > Yeah, makes sense. Above words can be reconsidered. >