Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753894AbdIGDTE (ORCPT ); Wed, 6 Sep 2017 23:19:04 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34618 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753648AbdIGDTB (ORCPT ); Wed, 6 Sep 2017 23:19:01 -0400 X-Google-Smtp-Source: ADKCNb7lhv+eHoRA3kztTJI4SLs22diiqCt5iNowRv+1Qxvf0G/VPUr7do+Z/T9ST7Y59YkZmYe82A== From: Taeung Song To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, taeung@kosslab.kr, Jiri Olsa , Namhyung Kim Subject: [PATCH v5 3/3] perf config: Allow creating empty config set for config file autogeneration Date: Thu, 7 Sep 2017 12:18:56 +0900 Message-Id: <1504754336-9824-1-git-send-email-treeze.taeung@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1534 Lines: 58 When there isn't a config file (e.g. ~/.perfconfig) or it has nothing, the config set wasn't created. If the config set not exists, a config file can't be autogenerated. So allow creating a empty config set in the above case, then we can support the config file autogeneration. Before: $ rm -f ~/.perfconfig $ perf config --user report.children=false $ cat ~/.perfconfig cat: /root/.perfconfig: No such file or directory But I think it should work even if there isn't a config file. After: $ rm -f ~/.perfconfig $ perf config --user report.children=false $ cat ~/.perfconfig # this file is auto-generated. [report] children = false NOTE: As a result, if perf_config_set__init() is failed, it seems that the config set isn't freed. But it isn't a problem. Because the config set will be freed by perf_config_set__delete() at the end of cmd_config(). Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/util/config.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index bc75596..d2b6983 100644 --- a/tools/perf/util/config.c +++ b/tools/perf/util/config.c @@ -700,10 +700,7 @@ struct perf_config_set *perf_config_set__new(void) if (set) { INIT_LIST_HEAD(&set->sections); - if (perf_config_set__init(set) < 0) { - perf_config_set__delete(set); - set = NULL; - } + perf_config_set__init(set); } return set; -- 2.7.4