Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754883AbdIGIue (ORCPT ); Thu, 7 Sep 2017 04:50:34 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:36493 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754860AbdIGIuc (ORCPT ); Thu, 7 Sep 2017 04:50:32 -0400 X-Google-Smtp-Source: ADKCNb5Kyush5IDNV6yzlBVQs6RoJlMTYUjGC+P1XVOxXNfSOk6MNcucJB5ipmqDsoWJCeRiZmiYSBAoh7NP66zxWvc= MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] In-Reply-To: <1504770561-5554-1-git-send-email-srishtishar@gmail.com> References: <1504770561-5554-1-git-send-email-srishtishar@gmail.com> From: Gilad Ben-Yossef Date: Thu, 7 Sep 2017 11:50:31 +0300 Message-ID: Subject: Re: [PATCH v5] Staging: ccree: Remove unused variable. To: Srishti Sharma Cc: Greg Kroah-Hartman , Linux Crypto Mailing List , driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, Linux kernel mailing list , outreachy-kernel@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1583 Lines: 50 Hi, On Thu, Sep 7, 2017 at 10:49 AM, Srishti Sharma wrote: > Remove the local variable inflight_counter as it is never used. > > Signed-off-by: Srishti Sharma > --- I've been meaning to clean that for some time now and never got around to do it. Thank you! :-) Acked-by: Gilad Ben-Yossef > Changes in v5: > - Correct the format of the subject. > drivers/staging/ccree/ssi_cipher.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c > index 8d31a93..1ff3c8a 100644 > --- a/drivers/staging/ccree/ssi_cipher.c > +++ b/drivers/staging/ccree/ssi_cipher.c > @@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev, > void __iomem *cc_base) > { > int completion_error = 0; > - u32 inflight_counter; > struct ablkcipher_request *req = (struct ablkcipher_request *)areq; > > ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst); > > - /*Set the inflight couter value to local variable*/ > - inflight_counter = ctx_p->drvdata->inflight_counter; > /*Decrease the inflight counter*/ > if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0) > ctx_p->drvdata->inflight_counter--; > -- > 2.7.4 > -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru