Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932075AbdIGJRD (ORCPT ); Thu, 7 Sep 2017 05:17:03 -0400 Received: from www62.your-server.de ([213.133.104.62]:44803 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754349AbdIGJRC (ORCPT ); Thu, 7 Sep 2017 05:17:02 -0400 Message-ID: <59B10E84.9090801@iogearbox.net> Date: Thu, 07 Sep 2017 11:16:52 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: naresh.kamboju@linaro.org, shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org CC: linux-kernel@vger.kernel.org, davem@davemloft.net, alexei.starovoitov@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH v2 1/2] selftests: bpf: test_kmod.sh: check if module is present in the path before insert References: <1504772342-21878-1-git-send-email-naresh.kamboju@linaro.org> In-Reply-To: <1504772342-21878-1-git-send-email-naresh.kamboju@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1664 Lines: 50 On 09/07/2017 10:19 AM, naresh.kamboju@linaro.org wrote: > From: Naresh Kamboju > > The test script works when kernel source and build module test_bpf.ko > present on the machine. This patch will check if module is present in > the path. > > Signed-off-by: Naresh Kamboju Looks good, what changed between v1 and v2? Didn't get the cover letter in case there was one. ;) Which tree are you targeting? There are usually a lot of changes in BPF selftests going the usual route via net and net-next tree as we often require to put test cases along the BPF patches. Given the merge window now and given one can regard it as a fix, it's net tree. I'm also ok if Shuah wants to pick it up this window as test_kmod.sh hasn't been changed in quite a while, so no merge conflicts expected. Anyway, for the patch: Acked-by: Daniel Borkmann Thanks! > --- > tools/testing/selftests/bpf/test_kmod.sh | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/bpf/test_kmod.sh b/tools/testing/selftests/bpf/test_kmod.sh > index 6d58cca8e235..a53eb1cb54ef 100755 > --- a/tools/testing/selftests/bpf/test_kmod.sh > +++ b/tools/testing/selftests/bpf/test_kmod.sh > @@ -9,9 +9,11 @@ test_run() > > echo "[ JIT enabled:$1 hardened:$2 ]" > dmesg -C > - insmod $SRC_TREE/lib/test_bpf.ko 2> /dev/null > - if [ $? -ne 0 ]; then > - rc=1 > + if [ -f $SRC_TREE/lib/test_bpf.ko ]; then > + insmod $SRC_TREE/lib/test_bpf.ko 2> /dev/null > + if [ $? -ne 0 ]; then > + rc=1 > + fi > fi > rmmod test_bpf 2> /dev/null > dmesg | grep FAIL >