Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755261AbdIGJkY (ORCPT ); Thu, 7 Sep 2017 05:40:24 -0400 Received: from mail.skyhub.de ([5.9.137.197]:47926 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754919AbdIGJkW (ORCPT ); Thu, 7 Sep 2017 05:40:22 -0400 Date: Thu, 7 Sep 2017 11:40:15 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Brian Gerst , Andrew Cooper , Juergen Gross , Boris Ostrovsky , Kees Cook Subject: Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label Message-ID: <20170907094015.c3kcmt4xbzhp6r4c@pd.tnic> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 845 Lines: 29 On Wed, Sep 06, 2017 at 02:36:46PM -0700, Andy Lutomirski wrote: > The only user was the 64-bit opportunistic SYSRET failure path, and > that path didn't really need it. This change makes the > opportunistic SYSRET code a bit more straightforward and gets rid of > the label. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/entry/entry_64.S | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Btw, you need to refresh your stuff because of those UNWIND_HINT_EMPTY things. I get: checking file arch/x86/entry/entry_64.S Hunk #1 succeeded at 245 (offset 5 lines). Hunk #2 FAILED at 308. Hunk #3 succeeded at 637 (offset 88 lines). 1 out of 3 hunks FAILED Otherwise Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.