Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755180AbdIGJlR (ORCPT ); Thu, 7 Sep 2017 05:41:17 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:41387 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754509AbdIGJlQ (ORCPT ); Thu, 7 Sep 2017 05:41:16 -0400 Date: Thu, 7 Sep 2017 11:41:09 +0200 From: Peter Zijlstra To: Byungchul Park Cc: tj@kernel.org, johannes.berg@intel.com, mingo@kernel.org, tglx@linutronix.de, oleg@redhat.com, david@fromorbit.com, linux-kernel@vger.kernel.org, kernel-team@lge.com Subject: Re: [PATCH] lockdep: Remove unnecessary acquisitions wrt workqueue flush Message-ID: <20170907094109.t5qzs3glfx32l327@hirez.programming.kicks-ass.net> References: <1504744396-4182-1-git-send-email-byungchul.park@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504744396-4182-1-git-send-email-byungchul.park@lge.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 377 Lines: 7 On Thu, Sep 07, 2017 at 09:33:16AM +0900, Byungchul Park wrote: > Workqueue added manual acquisitions to catch deadlock cases. Now > crossrelease was introduced, some of those are redundant because > crossrelease-enabled wait_for_completeion() also does it. Removed it. This does not explain how it doesn't become the regular timing dependent stuff cross-release normally is.