Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755080AbdIGLVN (ORCPT ); Thu, 7 Sep 2017 07:21:13 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:34048 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755032AbdIGLVL (ORCPT ); Thu, 7 Sep 2017 07:21:11 -0400 X-Google-Smtp-Source: ADKCNb6aAwGUMWvpb0m2PUKqXANwCP2t/gi/gcDED0kDIi818GMAdV57LrsYK3QlueoHJI1m2VxjFUYLaTc1R0KR4CM= MIME-Version: 1.0 In-Reply-To: <20170907101017.mcxfnm3u4osda7xr@sirena.co.uk> References: <20170906150446.v7qqc24wxeykcwwk@sirena.co.uk> <20170907101017.mcxfnm3u4osda7xr@sirena.co.uk> From: Baolin Wang Date: Thu, 7 Sep 2017 19:21:10 +0800 Message-ID: Subject: Re: [PATCH 2/2] spi: Add ADI driver for Spreadtrum platform To: Mark Brown Cc: Baolin Wang , Rob Herring , Mark Rutland , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1098 Lines: 28 On 7 September 2017 at 18:10, Mark Brown wrote: > On Thu, Sep 07, 2017 at 11:13:00AM +0800, Baolin Wang wrote: > >> >> +static int __init sprd_adi_init(void) >> >> +{ >> >> + return platform_driver_register(&sprd_adi_driver); >> >> +} >> >> +subsys_initcall(sprd_adi_init); > >> > Why is this subsys_initcall() and not module_platform_driver()? > >> Since ADI is one very fundamental driver for our SoC, many drivers >> such as regulator need depend on ADI, and regulator need to regulate >> core voltage as earlier as possible. > > That applies to huge numbers of systems - you should still just use > regular init ordering in mainline, there are efforts to make things > better there (look at Viresh's dependency stuff) so hopefully things > will improve in the future and in the meantime the cost of probe > deferral isn't *that* great and it's less fiddly than tweaking ordering. > Practically speaking init ordering stuff can always be added in vendor > kernels in the meantime. Make sense. So I change back to module_platform_driver(). -- Baolin.wang Best Regards