Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755238AbdIGL1w (ORCPT ); Thu, 7 Sep 2017 07:27:52 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:45864 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754761AbdIGL1t (ORCPT ); Thu, 7 Sep 2017 07:27:49 -0400 X-AuditID: cbfec7f2-f793b6d000003243-cf-59b12d32682a Subject: Re: [PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible. To: Hoegeun Kwon , inki.dae@samsung.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Marek Szyprowski Message-id: Date: Thu, 07 Sep 2017 13:27:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-version: 1.0 In-reply-to: <1504777143-29834-3-git-send-email-hoegeun.kwon@samsung.com> Content-type: text/plain; charset="utf-8"; format="flowed" Content-transfer-encoding: 7bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTYRTHeXbvtutodpvWTipawyQ0NU3oqmmpBVf6Ul+iaVC3vKj42jYl C1KL+TJn2sKyIVr4RmOhzmXSi7BlaUnzJVEsUMtQMtTMDBWxnLvCvv3O/5zn+T//w0Ngkg98 DyI1U8UqMpl0mUCEd7xb7Q8MDWyTH/7TEESV297zqIUmLaLqum18anh5QUAtNGsElG6iEqcq pn5iVH9/q5AyTY3wqU8vagRUdX8Xj2ocHeRR6tfdQurHYi9+wpU21hoRbTKUCujnfyf59ERZ D49ub8in75gNiF4yeZ8RJoiOJbHpqbmsIjj6kijl15MGlK2WXqua9S1AxRINciGADAPD+LTQ wXtgYLxFoEEiQkI2Iqgpr+Q5iiUElod9vO0TWu1LrtGE4Gu9FnMUMwj+dTfj9ik38jSYdaat KXdyCMFE4YjQXmCkAcFnfS2yTwnIENDMaTYdCUJMRsMzW6pdxskD0DRZwrfzbvICFFvHMDuL yV2wcm98y8CFjIf1rrotHSMjYHpDzXewD7Qb5zhdCrfVY7jdF8haIdjMNVyGk2Cp0HLsBrM9 Zm4DXlBaYuH0CgS31AEOrkZgmxM7OBLe9AxyZq6g63iA2d8PpBhKiril0nB/bYC7Jgamv3Vy S/2CQDc0z69EPnqnPHqnDHqnDHqnDI8QbkDubI4yI5lVHglSMhnKnMzkoCtZGSa0+cP6Nnp+ d6Ll3ggrIgkk2yEu8GyVS/hMrjIvw4qAwGTuYq+ANrlEnMTkXWcVWRcVOems0oo8CVwmFUcl FMklZDKjYtNYNptVbHd5hItHAWKK5h83n7L4iYQjobELVUsbRI1q+sbUIRpTtXglnc/M++gv SCsWXRYl1gcxDZheHfj9+HDszqdH77aajDFY81CcylvKzrkuHrx5dfQsCpfl5EcXzkQVm+rN Qysj65X71iTnqnm+bfGv3soTI4P96srCXBM9x6R7w/ez+yxxqzJcmcKE+GMKJfMfmDBYll0D AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsVy+t/xq7pGuhsjDf7fFLXoPXeSyeL9sh5G i/lHzrFaXPn6ns3i/fIuNotJ9yewWPQ/fs1scf78BnaLTY+vsVpc3jWHzWLG+X1MFkuvX2Sy aN17hN3i5ccTLA58HmvmrWH02LSqk81j+7cHrB73u48zeWxeUu/Rt2UVo8fnTXIB7FFcNimp OZllqUX6dglcGR9WLmEsaBWvmPpKpYGxXaiLkZNDQsBEoqdnNxOELSZx4d56ti5GLg4hgSWM EpubjrBAOM8ZJfpWvmMEqRIW8JbYMmkTE0hCROASo8SSk/OYQRxmgVWMEnM/PmWFaLnNKNG2 YCo7SAubgKFE19suoMEcHLwCdhJbz2WChFkEVCWWPehgBbFFBWIkfl56xAJi8woISvyYfA/M 5hTwlPizbz4ziM0sYCbx5eVhVghbXmLzmrdQcXGJ5tabLBMYBWchaZ+FpGUWkpZZSFoWMLKs YhRJLS3OTc8tNtQrTswtLs1L10vOz93ECIy3bcd+bt7BeGlj8CFGAQ5GJR7ehP/rI4VYE8uK K3MPMUpwMCuJ8Mpob4wU4k1JrKxKLcqPLyrNSS0+xCjNwaIkztu7Z3WkkEB6YklqdmpqQWoR TJaJg1OqgVHXfnoPY2bCZA+XzYcu6vC6FjIv+D1xboSxfMA7vXsbv/196b0/SPX9Z7bYmmNN m1aeWFA361SUSrbmxRNHFia2ybOozZrWy9kc27600uq7zCnxdaZvn5599uHHysepB4zjam4w 3b0us5396OOsWc5SqrZRm08cWSwS5B5aV2t7JjqZM6x0eqESS3FGoqEWc1FxIgDQtQ5FswIA AA== X-CMS-MailID: 20170907112746eucas1p23f9ea290c4eb6a8b138508a023d452e9 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-CMS-RootMailID: 20170907093912epcas2p2c012de3af3915a58d889c2d48e283705 X-RootMTR: 20170907093912epcas2p2c012de3af3915a58d889c2d48e283705 References: <1504777143-29834-1-git-send-email-hoegeun.kwon@samsung.com> <1504777143-29834-3-git-send-email-hoegeun.kwon@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2862 Lines: 85 Hi Hoegeun, On 2017-09-07 11:39, Hoegeun Kwon wrote: > Exynos 5250 and 5420 have different hardware rotation limits. However, > currently it uses only one compatible - "exynos5-gsc". Since we have > to distinguish between these two, we add different compatible. > > Signed-off-by: Hoegeun Kwon The new values (5250/5420 specific) should replace old exynos5-gsc, there is no point providing both in dts. > --- > arch/arm/boot/dts/exynos5250.dtsi | 8 ++++---- > arch/arm/boot/dts/exynos5420.dtsi | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index 8dbeb87..f795c76 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -637,7 +637,7 @@ > }; > > gsc_0: gsc@13e00000 { > - compatible = "samsung,exynos5-gsc"; > + compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc"; > reg = <0x13e00000 0x1000>; > interrupts = ; > power-domains = <&pd_gsc>; > @@ -647,7 +647,7 @@ > }; > > gsc_1: gsc@13e10000 { > - compatible = "samsung,exynos5-gsc"; > + compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc"; > reg = <0x13e10000 0x1000>; > interrupts = ; > power-domains = <&pd_gsc>; > @@ -657,7 +657,7 @@ > }; > > gsc_2: gsc@13e20000 { > - compatible = "samsung,exynos5-gsc"; > + compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc"; > reg = <0x13e20000 0x1000>; > interrupts = ; > power-domains = <&pd_gsc>; > @@ -667,7 +667,7 @@ > }; > > gsc_3: gsc@13e30000 { > - compatible = "samsung,exynos5-gsc"; > + compatible = "samsung,exynos5-gsc", samsung,exynos5250-gsc"; > reg = <0x13e30000 0x1000>; > interrupts = ; > power-domains = <&pd_gsc>; > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index 02d2f89..86afe77 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -658,7 +658,7 @@ > }; > > gsc_0: video-scaler@13e00000 { > - compatible = "samsung,exynos5-gsc"; > + compatible = "samsung,exynos5-gsc", "samsung,exynos5420-gsc"; > reg = <0x13e00000 0x1000>; > interrupts = ; > clocks = <&clock CLK_GSCL0>; > @@ -668,7 +668,7 @@ > }; > > gsc_1: video-scaler@13e10000 { > - compatible = "samsung,exynos5-gsc"; > + compatible = "samsung,exynos5-gsc", "samsung,exynos5420-gsc"; > reg = <0x13e10000 0x1000>; > interrupts = ; > clocks = <&clock CLK_GSCL1>; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland