Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755240AbdIGLgL (ORCPT <rfc822;w@1wt.eu>);
        Thu, 7 Sep 2017 07:36:11 -0400
Received: from alexa-out.qualcomm.com ([129.46.98.28]:25249 "EHLO
        alexa-out-lv-02.qualcomm.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1755092AbdIGLgJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Sep 2017 07:36:09 -0400
X-IronPort-AV: E=Sophos;i="5.42,358,1500966000"; 
   d="scan'208";a="4884522"
X-IronPort-AV: E=McAfee;i="5900,7806,8646"; a="1029190679"
X-MGA-submission: =?us-ascii?q?MDEXkvIFVyEX3doTRrrwQqRqhg6Gd7Xs5Sr3PN?=
 =?us-ascii?q?vAwPVqKZNyne4OqMY7x1DuPLpOlUeBDHxjlOCy9k8YQDp4KI9QFg+zmw?=
 =?us-ascii?q?eewijNy0CwLiyBW9gjjbDPa+rnk3kEKH6ojcyXpD3FQnqQEGG4pIpbuc?=
 =?us-ascii?q?La?=
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: Colin Ian King <colin.king@canonical.com>,
        "bartosz.markowski@tieto.com" <bartosz.markowski@tieto.com>,
        Govind Singh <govinds@qti.qualcomm.com>,
        "Ryan Hsu" <ryanhsu@qti.qualcomm.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
        Ashok Raj Nagarajan <arnagara@qti.qualcomm.com>,
        Ben Greear <greearb@candelatech.com>,
        "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ath10: mark PM functions as __maybe_unused
Thread-Topic: [PATCH] ath10: mark PM functions as __maybe_unused
Thread-Index: AQHTJw/1Nh/jAszSbUuiSym3ueAQgw==
Date: Thu, 7 Sep 2017 11:36:05 +0000
Message-ID: <87o9qmn3kr.fsf@kamboji.qca.qualcomm.com>
References: <20170906125904.2588620-1-arnd@arndb.de>
In-Reply-To: <20170906125904.2588620-1-arnd@arndb.de> (Arnd Bergmann's message
        of "Wed, 6 Sep 2017 14:58:53 +0200")
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.251.52.12]
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v87BaGPa021217
Content-Length: 834
Lines: 21

Arnd Bergmann <arnd@arndb.de> writes:

> When CONFIG_PM_SLEEP is disabled, we get a compile-time
> warning:
>
> drivers/net/wireless/ath/ath10k/pci.c:3417:12: error: 'ath10k_pci_pm_resume' defined but not used [-Werror=unused-function]
>  static int ath10k_pci_pm_resume(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath10k/pci.c:3401:12: error: 'ath10k_pci_pm_suspend' defined but not used [-Werror=unused-function]
>  static int ath10k_pci_pm_suspend(struct device *dev)
>
> Rather than fixing the #ifdef, this just marks both functions
> as __maybe_unused, which is a more robust way to do this.
>
> Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks. But the title should have "ath10k:", I'll fix that.

-- 
Kalle Valo