Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755332AbdIGLoT (ORCPT ); Thu, 7 Sep 2017 07:44:19 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:59874 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755169AbdIGLoR (ORCPT ); Thu, 7 Sep 2017 07:44:17 -0400 Date: Thu, 7 Sep 2017 12:44:01 +0100 From: Mark Brown To: Baolin Wang Cc: Baolin Wang , Rob Herring , Mark Rutland , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, LKML Subject: Re: [PATCH 1/2] dt-bindings: spi: Add Spreadtrum ADI controller documentation Message-ID: <20170907114401.kz2rfss2bkslybtq@sirena.co.uk> References: <20170906145900.yesyfyruv5wd3wxj@sirena.co.uk> <20170907095435.5yhybxz6oootp37h@sirena.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vguk34mvr5spuvig" Content-Disposition: inline In-Reply-To: X-Cookie: Do unto others before they undo you. User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1872 Lines: 48 --vguk34mvr5spuvig Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 07, 2017 at 07:03:18PM +0800, Baolin Wang wrote: > On 7 September 2017 at 17:54, Mark Brown wrote: > > On Thu, Sep 07, 2017 at 11:29:05AM +0800, Baolin Wang wrote: > >> The hwspinlock name should be "adi", and I will make it clear in next version. > > So there's other drivers that might also be accessing this IP block? > Yes. Other drivers (like regulator, RTC or charger ... ) can access > analog chip (like PMIC) by ADI controller. But the hardware spinlock > is used to synchronize between the multiple subsystems, since we only > have one ADI controller. If it were other drivers then the kernel should already be doing that but... > > So does this driver control all the channels or are there other drivers > > (or hardware components) that control some of the other channels? > The ADI driver only controls 2 software channels (read/write), and > other hardware channels can be controlled by hardware components if we > set the hardware config. ...if it can be configured to allow other things to use it independently then this is fine, just needs a bit more documentation so someone can understand how the bindings and hardware match up. --vguk34mvr5spuvig Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmxMQAACgkQJNaLcl1U h9BsMwf8CG0Ejhc4sKcJgClOTN/XPVwI52R/pobIErQ50ERLnh1/r/mZEbI1EyPH IqWqzB45nVrU5ZKpUy+bw+TgM8Cv6eakcfmUNsltV9eQgPXAFSiH6JIOEN0STXB7 wBYCfRJ2wyhHcOMmy7/9nbVQcH1h34xuKJN8ERPE+Q23f3UauE/Lu4yWjgMHmPtW mai+0fzwJswUVq9wf9KIuBDlXRwIkGI7wJDrSzh5sqLHKBV0WMTszwf70bcq6/pk THI4OYU8dvksoEBiv3gzN9VIKwQLqwTeOPGwmUFMbldonZyta7qRx/+7GcnUsIJf P0SsklPOhwzmJ4Zej24LiIT5fKI8gA== =wXNB -----END PGP SIGNATURE----- --vguk34mvr5spuvig--