Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755459AbdIGOQt (ORCPT ); Thu, 7 Sep 2017 10:16:49 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:38572 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754005AbdIGOQr (ORCPT ); Thu, 7 Sep 2017 10:16:47 -0400 X-Google-Smtp-Source: ADKCNb5T9f9mN9xkinffEKL4jJTq/2bSOAKxwiEl7ZLLPRS3tpTPGdEXkkDtHhK/KJlTSC3BTKizFgrHs0wMBg1pod8= MIME-Version: 1.0 In-Reply-To: <20170906195825.3715290-1-arnd@arndb.de> References: <20170906195825.3715290-1-arnd@arndb.de> From: Geert Uytterhoeven Date: Thu, 7 Sep 2017 16:16:46 +0200 X-Google-Sender-Auth: H5DIKqgCGj_TJ7R4BxVO7-am0CU Message-ID: Subject: Re: [PATCH] netfilter: xt_hashlimit: avoid 64-bit division To: Arnd Bergmann Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Vishwanath Pai , Josh Hunt , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1096 Lines: 30 Hi Arnd, On Wed, Sep 6, 2017 at 9:57 PM, Arnd Bergmann wrote: > 64-bit division is expensive on 32-bit architectures, and > requires a special function call to avoid a link error like: > > net/netfilter/xt_hashlimit.o: In function `hashlimit_mt_common': > xt_hashlimit.c:(.text+0x1328): undefined reference to `__aeabi_uldivmod' > > In the case of hashlimit_mt_common, we don't actually need a > 64-bit operation, we can simply rewrite the function slightly > to make that clear to the compiler. > > Fixes: bea74641e378 ("netfilter: xt_hashlimit: add rate match mode") > Signed-off-by: Arnd Bergmann Thanks, this fixes a similar issue (__udivdi3 undefined) on m68k. Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds