Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932284AbdIGOgF (ORCPT ); Thu, 7 Sep 2017 10:36:05 -0400 Received: from gateway22.websitewelcome.com ([192.185.46.131]:41108 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932184AbdIGOgE (ORCPT ); Thu, 7 Sep 2017 10:36:04 -0400 Subject: Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches To: Larry Finger , Chaoming Li , Kalle Valo References: <20170830134223.GA13596@embeddedgus> Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Message-ID: <02176aa2-9af5-c933-74e1-b2333c07c36b@embeddedor.com> Date: Thu, 7 Sep 2017 09:35:49 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.147.97 X-Exim-ID: 1dpxuM-0012Qa-LT X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.70]) [189.152.147.97]:50542 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 36 Hi Larry, On 08/30/2017 11:48 PM, Larry Finger wrote: > On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: >> Refactor code in order to avoid identical code for different branches. >> >> This issue was detected with the help of Coccinelle. >> >> Addresses-Coverity-ID: 1226788 >> Signed-off-by: Gustavo A. R. Silva >> --- >> This issue was reported by Coverity and it was tested by compilation >> only. >> I'm suspicious this may be a copy/paste error. Please, verify. >> >> .../net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c | 10 >> ++-------- >> 1 file changed, 2 insertions(+), 8 deletions(-) > > This change is not correct. When bt_link_info->sco_exist is true, the > call should be > > halbtc8723b1ant_limited_rx(btcoexist, > NORMAL_EXEC, true, > false, 0x5); > > NACK > > I will push the correct patch. > Great. Good to know. Thanks -- Gustavo A. R. Silva