Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754610AbdIGQka (ORCPT ); Thu, 7 Sep 2017 12:40:30 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33548 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753640AbdIGQk1 (ORCPT ); Thu, 7 Sep 2017 12:40:27 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7EF7C601CF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: iwlwifi: mvm: only send LEDS_CMD when the FW supports it From: Kalle Valo In-Reply-To: <20170907075152.4522-1-luca@coelho.fi> References: <20170907075152.4522-1-luca@coelho.fi> To: Luciano Coelho Cc: torvalds@linux-foundation.org, linux-wireless@vger.kernel.org, johannes@sipsolutions.net, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, netdev@vger.kernel.org, davem@davemloft.net, emmanuel.grumbach@intel.com, Luca Coelho User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20170907164027.2C5926073D@smtp.codeaurora.org> Date: Thu, 7 Sep 2017 16:40:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1094 Lines: 28 Luciano Coelho wrote: > From: Luca Coelho > > The LEDS_CMD command is only supported in some newer FW versions > (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions > (such as iwlwifi-8000C-27.ucode). > > To fix this, check for a new bit in the FW capabilities TLV that tells > when the command is supported. > > Note that the current version of -31.ucode in linux-firmware.git > (31.532993.0) does not have this capability bit set, so the LED won't > work, even though this version should support it. But we will update > this firmware soon, so it won't be a problem anymore. > > Fixes: 7089ae634c50 ("iwlwifi: mvm: use firmware LED command where applicable") > Reported-by: Linus Torvalds > Signed-off-by: Luca Coelho Patch applied to wireless-drivers.git, thanks. 2eabc84d2f8e iwlwifi: mvm: only send LEDS_CMD when the FW supports it -- https://patchwork.kernel.org/patch/9941719/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches