Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754402AbdIGQuJ (ORCPT ); Thu, 7 Sep 2017 12:50:09 -0400 Received: from smtprelay0251.hostedemail.com ([216.40.44.251]:40251 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751456AbdIGQuI (ORCPT ); Thu, 7 Sep 2017 12:50:08 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1561:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3867:3868:3870:3871:3874:4321:5007:10004:10400:10848:11026:11232:11658:11914:12346:12438:12740:12760:12895:13069:13311:13357:13439:14181:14659:21080:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: dirt34_cc4f552d456 X-Filterd-Recvd-Size: 1814 Message-ID: <1504803003.7546.24.camel@perches.com> Subject: Re: [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages From: Joe Perches To: Helge Deller , Sergey Senozhatsky Cc: linux-kernel@vger.kernel.org, Sergey Senozhatsky , Petr Mladek , Andrew Morton , Tony Luck , Fenghua Yu , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Date: Thu, 07 Sep 2017 09:50:03 -0700 In-Reply-To: <0604f27e-24ab-625b-9013-c6c0f4f6acc1@gmx.de> References: <1504729681-3504-1-git-send-email-deller@gmx.de> <20170907004522.GA3885@jagdpanzerIV.localdomain> <8b93f9ca-95f6-4e40-1cc8-d1a65833abff@gmx.de> <20170907075653.GA533@jagdpanzerIV.localdomain> <20170907083207.GC533@jagdpanzerIV.localdomain> <667b8849-fb60-a312-2483-505252ff737e@gmx.de> <20170907093631.GD533@jagdpanzerIV.localdomain> <20170907095119.GE533@jagdpanzerIV.localdomain> <0604f27e-24ab-625b-9013-c6c0f4f6acc1@gmx.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 290 Lines: 6 On Thu, 2017-09-07 at 14:38 +0200, Helge Deller wrote: > Instead, maybe adding some checks to scripts/checkpatch.pl can help? > E.g. warn if %pF is used in combination with the keywords like > _builtin_return_address, _RET_IP_, and similar. coccinelle is probably a better tool for that.