Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755664AbdIGR4d (ORCPT ); Thu, 7 Sep 2017 13:56:33 -0400 Received: from mga09.intel.com ([134.134.136.24]:39783 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755590AbdIGR4b (ORCPT ); Thu, 7 Sep 2017 13:56:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,359,1500966000"; d="scan'208";a="149347722" From: kan.liang@intel.com To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org Cc: jolsa@kernel.org, namhyung@kernel.org, adrian.hunter@intel.com, lukasz.odzioba@intel.com, ak@linux.intel.com, Kan Liang Subject: [PATCH RFC 03/10] petf tools: using comm_str to replace comm in hist_entry Date: Thu, 7 Sep 2017 10:55:47 -0700 Message-Id: <1504806954-150842-4-git-send-email-kan.liang@intel.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1504806954-150842-1-git-send-email-kan.liang@intel.com> References: <1504806954-150842-1-git-send-email-kan.liang@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2721 Lines: 83 From: Kan Liang For hist_entry, it only needs comm_str for cmp. Signed-off-by: Kan Liang --- tools/perf/util/hist.c | 4 ++-- tools/perf/util/sort.c | 8 ++++---- tools/perf/util/sort.h | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index e60d8d8..0f00dd9 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -587,7 +587,7 @@ __hists__add_entry(struct hists *hists, struct namespaces *ns = thread__namespaces(al->thread); struct hist_entry entry = { .thread = al->thread, - .comm = thread__comm(al->thread), + .comm_str = thread__comm_str(al->thread), .cgroup_id = { .dev = ns ? ns->link_info[CGROUP_NS_INDEX].dev : 0, .ino = ns ? ns->link_info[CGROUP_NS_INDEX].ino : 0, @@ -944,7 +944,7 @@ iter_add_next_cumulative_entry(struct hist_entry_iter *iter, .hists = evsel__hists(evsel), .cpu = al->cpu, .thread = al->thread, - .comm = thread__comm(al->thread), + .comm_str = thread__comm_str(al->thread), .ip = al->addr, .ms = { .map = al->map, diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index eb3ab90..99ab411 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -114,26 +114,26 @@ static int64_t sort__comm_cmp(struct hist_entry *left, struct hist_entry *right) { /* Compare the addr that should be unique among comm */ - return strcmp(comm__str(right->comm), comm__str(left->comm)); + return strcmp(right->comm_str, left->comm_str); } static int64_t sort__comm_collapse(struct hist_entry *left, struct hist_entry *right) { /* Compare the addr that should be unique among comm */ - return strcmp(comm__str(right->comm), comm__str(left->comm)); + return strcmp(right->comm_str, left->comm_str); } static int64_t sort__comm_sort(struct hist_entry *left, struct hist_entry *right) { - return strcmp(comm__str(right->comm), comm__str(left->comm)); + return strcmp(right->comm_str, left->comm_str); } static int hist_entry__comm_snprintf(struct hist_entry *he, char *bf, size_t size, unsigned int width) { - return repsep_snprintf(bf, size, "%-*.*s", width, width, comm__str(he->comm)); + return repsep_snprintf(bf, size, "%-*.*s", width, width, he->comm_str); } struct sort_entry sort_comm = { diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h index f36dc49..861cbe7 100644 --- a/tools/perf/util/sort.h +++ b/tools/perf/util/sort.h @@ -96,7 +96,7 @@ struct hist_entry { struct he_stat *stat_acc; struct map_symbol ms; struct thread *thread; - struct comm *comm; + const char *comm_str; struct namespace_id cgroup_id; u64 ip; u64 transaction; -- 2.5.5