Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755872AbdIGTni (ORCPT ); Thu, 7 Sep 2017 15:43:38 -0400 Received: from mail-yw0-f180.google.com ([209.85.161.180]:35129 "EHLO mail-yw0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752708AbdIGTng (ORCPT ); Thu, 7 Sep 2017 15:43:36 -0400 X-Google-Smtp-Source: ADKCNb7b1TwoUORsmV3RlT/reGVvEbX31ou5/vNNPmb2iribaD6sF1X/NhFEx3bkMWwVCJaOvMJsga9iX/sZv4BOrvo= MIME-Version: 1.0 In-Reply-To: <20170907184745.GA20598@castle.DHCP.thefacebook.com> References: <20170829100150.4580-1-guro@fb.com> <20170829192621.GA5447@cmpxchg.org> <20170830105524.GA2852@castle.dhcp.TheFacebook.com> <20170907184745.GA20598@castle.DHCP.thefacebook.com> From: Shakeel Butt Date: Thu, 7 Sep 2017 12:43:35 -0700 Message-ID: Subject: Re: [PATCH] mm: memcontrol: use per-cpu stocks for socket memory uncharging To: Roman Gushchin Cc: Johannes Weiner , Linux MM , Michal Hocko , Vladimir Davydov , cgroups@vger.kernel.org, kernel-team@fb.com, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 711 Lines: 20 On Thu, Sep 7, 2017 at 11:47 AM, Roman Gushchin wrote: > On Thu, Sep 07, 2017 at 11:44:12AM -0700, Shakeel Butt wrote: >> >> As far as other types of pages go: page cache and anon are already >> >> batched pretty well, but I think kmem might benefit from this >> >> too. Have you considered using the stock in memcg_kmem_uncharge()? >> > >> > Good idea! >> > I'll try to find an appropriate testcase and check if it really >> > brings any benefits. If so, I'll master a patch. >> > >> >> Hi Roman, did you get the chance to try this on memcg_kmem_uncharge()? > > Hi Shakeel! > > Not yet, I'll try to it asap. > Do you have an example when it's costly? > Nah, I was also curious of such examples.