Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932890AbdIGUC3 (ORCPT ); Thu, 7 Sep 2017 16:02:29 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:35608 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932846AbdIGUCW (ORCPT ); Thu, 7 Sep 2017 16:02:22 -0400 X-Google-Smtp-Source: AOwi7QBc2k3CJxrCL/WjkD/YzRIywUkbbTMw+ejw+CfLZM8GTYZuakuMSFU/RfaUKWPf9YjR2HiuPNynZkqI77iJ22I= MIME-Version: 1.0 In-Reply-To: References: <20170905194739.GA31241@amd> <8f0f7310-ea4d-a200-75fd-23509947fb38@rock-chips.com> <6689241f-a4d8-7a3e-9f0b-482b034e5710@intel.com> From: Linus Walleij Date: Thu, 7 Sep 2017 22:02:20 +0200 Message-ID: Subject: Re: 4.13 on thinkpad x220: oops when writing to SD card To: Ulf Hansson Cc: Adrian Hunter , Shawn Lin , Pavel Machek , "linux-mmc@vger.kernel.org" , kernel list , Seraphime Kirkovski Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1127 Lines: 30 On Thu, Sep 7, 2017 at 9:18 AM, Ulf Hansson wrote: > Even if this fixes the problem it seems like we are papering over the > real issue, which earlier fixes also did during the release cycle for > v4.13. I think this is the real solution to the issue. >> Another unrelated issue with mmc_init_request() is that mmc_exit_request() >> is not called if mmc_init_request() fails, which means mmc_init_request() >> must free anything it allocates when it fails. > > Yes, the situations it's just too fragile. We need to fix the behavior > properly, although I haven't myself been able to investigate exactly > how yet. > > Adding, Linus, perhaps he has some ideas. Maybe we should simply bite the bullet and do what was suggested by another contributor when I refactored the bounce buffer handling: simply delete the bounce buffer code and let any remaining (few?) legacy devices suffer a bit (performancewise) at the gain of way simpler code? I am a bit hesitant about that because Pierre Ossman said it was actually a big win on the SDHC hosts that made use of it at one point. Yours, Linus Walleij