Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932727AbdIGUCN (ORCPT ); Thu, 7 Sep 2017 16:02:13 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:52058 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756184AbdIGUCG (ORCPT ); Thu, 7 Sep 2017 16:02:06 -0400 Date: Thu, 7 Sep 2017 14:01:53 -0600 From: Jason Gunthorpe To: Arnd Bergmann Cc: Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , Colin Ian King , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm: constify transmit data pointers Message-ID: <20170907200153.GA6350@obsidianresearch.com> References: <20170907133130.2463746-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170907133130.2463746-1-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1498 Lines: 27 On Thu, Sep 07, 2017 at 03:30:45PM +0200, Arnd Bergmann wrote: > Making cmd_getticks 'const' introduced a couple of harmless warnings: > > drivers/char/tpm/tpm_tis_core.c: In function 'probe_itpm': > drivers/char/tpm/tpm_tis_core.c:469:31: error: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] > rc = tpm_tis_send_data(chip, cmd_getticks, len); > drivers/char/tpm/tpm_tis_core.c:477:31: error: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] > rc = tpm_tis_send_data(chip, cmd_getticks, len); > drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}' > static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len) > > This changes the related functions to all take 'const' pointers > so that gcc can see this as being correct. I had to slightly > modify the logic around tpm_tis_spi_transfer() for this to work > without introducing ugly casts. > > Fixes: 5e35bd8e06b9 ("tpm_tis: make array cmd_getticks static const to shink object code size") > Signed-off-by: Arnd Bergmann Reviewed-by: Jason Gunthorpe Bit confused how the compile warnings introduced by the original patch were missed?? Jarkko do you run compile tests and sparse before sending pull requests? Cheers, Jason