Message-ID: <1504816041.30780.8.camel@linux.intel.com>
Subject: Re: [PATCH v8 09/28] x86/insn-eval: Do not BUG on invalid register
 type
From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
To: Borislav Petkov <bp@suse.de>
Cc: Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Brian Gerst <brgerst@gmail.com>, Chris Metcalf <cmetcalf@mellanox.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Masami Hiramatsu <mhiramat@kernel.org>, Huang Rui <ray.huang@amd.com>,
        Jiri Slaby <jslaby@suse.cz>, Jonathan Corbet <corbet@lwn.net>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Vlastimil Babka <vbabka@suse.cz>, Chen Yucong <slaoub@gmail.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Shuah Khan <shuah@kernel.org>, linux-kernel@vger.kernel.org,
        x86@kernel.org, Adam Buchbinder <adam.buchbinder@gmail.com>,
        Colin Ian King <colin.king@canonical.com>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Qiaowei Ren <qiaowei.ren@intel.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kees Cook <keescook@chromium.org>,
        Thomas Garnier <thgarnie@google.com>,
        Dmitry Vyukov <dvyukov@google.com>
Date: Thu, 07 Sep 2017 13:27:21 -0700
In-Reply-To: <20170907175413.5jyxbr3evv7bvock@pd.tnic>
References: <20170819002809.111312-1-ricardo.neri-calderon@linux.intel.com>
         <20170819002809.111312-10-ricardo.neri-calderon@linux.intel.com>
         <20170907175413.5jyxbr3evv7bvock@pd.tnic>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1100
Lines: 39

On Thu, 2017-09-07 at 19:54 +0200, Borislav Petkov wrote:
> 
> Also, I meant to add it to pr_fmt. Feel free to merge this hunk ontop
> of
> yours:
> 
> ---
> diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c
> index 3919458fecbf..d46034ddfbb7 100644
> --- a/arch/x86/lib/insn-eval.c
> +++ b/arch/x86/lib/insn-eval.c
> @@ -10,6 +10,9 @@
>  #include <asm/insn.h>
>  #include <asm/insn-eval.h>
>  
> +#undef pr_fmt
> +#define pr_fmt(fmt) "insn: " fmt
> +
>  enum reg_type {
>         REG_TYPE_RM = 0,
>         REG_TYPE_INDEX,
> @@ -86,7 +89,7 @@ static int get_reg_offset(struct insn *insn, struct
> pt_regs *regs,
>                 break;
>  
>         default:
> -               pr_err_ratelimited("insn: x86: invalid register
> type");
> +               pr_err_ratelimited("invalid register type: %d\n",
> type);
>                 return -EINVAL;
>         }
>  

Oh, I didn't understand your comment initially. Sure, I will add merge
this on top of my patch.

Thanks and BR,
Ricardo