Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756182AbdIGV1p (ORCPT ); Thu, 7 Sep 2017 17:27:45 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:45385 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755887AbdIGV1n (ORCPT ); Thu, 7 Sep 2017 17:27:43 -0400 X-Google-Smtp-Source: AOwi7QBDeW1PbQH3G1Qo6qRHQ7u0pKwlnFYah3lBVwTGMgE/uAHVFNvthZTL/vvcLfSjiD+Qa6PImw== Date: Thu, 7 Sep 2017 16:27:39 -0500 From: Seth Forshee To: Kees Cook Cc: linux-kernel@vger.kernel.org Subject: seccomp selftest fails to build with glibc 2.26 Message-ID: <20170907212739.72s3lbgoerumgxdj@ubuntu-hedt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1146 Lines: 34 Hi Kees, I'm seeing build failures with your seccomp selftest when using glibc 2.26. The first are related to changing macro names from __have_sig*_t to __sig*_t_defined. But after defining those there are more conflicting definitions. I was able to get it to build with the changes below, however it's ugly so I'm hesitant to suggest that it's a fix (and I haven't tested with older glibc either). The full build output is a little lengthy, so I've pasted it at http://pastebin.ubuntu.com/25486192/ rather than including it inline. Thanks, Seth diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c index 03f1fa49..d234a3e5 100644 --- a/tools/testing/selftests/seccomp/seccomp_bpf.c +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c @@ -11,6 +11,13 @@ #define __have_sigval_t 1 #define __have_sigevent_t 1 +/* These fix errors with glibc 2.26 */ +#define __siginfo_t_defined 1 +#define __sigval_t_defined 1 +#define __sigevent_t_defined 1 +#define _BITS_SIGINFO_CONSTS_H 1 +#define _BITS_SIGEVENT_CONSTS_H 1 + #include #include #include