Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755950AbdIGVyV (ORCPT ); Thu, 7 Sep 2017 17:54:21 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:60126 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbdIGVyT (ORCPT ); Thu, 7 Sep 2017 17:54:19 -0400 Date: Thu, 7 Sep 2017 23:54:17 +0200 From: Andrew Lunn To: Tristram.Ha@microchip.com Cc: muvarov@gmail.com, pavel@ucw.cz, nathan.leigh.conrad@gmail.com, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Woojung.Huh@microchip.com Subject: Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added Message-ID: <20170907215417.GU11248@lunn.ch> References: <93AF473E2DA327428DE3D46B72B1E9FD41121A5B@CHN-SV-EXMX02.mchp-main.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <93AF473E2DA327428DE3D46B72B1E9FD41121A5B@CHN-SV-EXMX02.mchp-main.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6703 Lines: 136 > -- compatible: For external switch chips, compatible string must be exactly one > - of: "microchip,ksz9477" > +- compatible: Should be "microchip,ksz9477" for KSZ9477 chip, > + "microchip,ksz8795" for KSZ8795 chip, > + "microchip,ksz8794" for KSZ8794 chip, > + "microchip,ksz8765" for KSZ8765 chip, > + "microchip,ksz8895" for KSZ8895 chip, > + "microchip,ksz8864" for KSZ8864 chip, > + "microchip,ksz8873" for KSZ8873 chip, > + "microchip,ksz8863" for KSZ8863 chip, > + "microchip,ksz8463" for KSZ8463 chip This part of this patch should be in a patch of the series that actually adds support for these chips. Don't document chips until you actually support them. > See Documentation/devicetree/bindings/dsa/dsa.txt for a list of additional required and optional properties. > @@ -13,60 +20,60 @@ Examples: > > Ethernet switch connected via SPI to the host, CPU port wired to eth0: > > - eth0: ethernet@10001000 { > - fixed-link { > - speed = <1000>; > - full-duplex; > - }; > - }; > + eth0: ethernet@10001000 { > + fixed-link { > + speed = <1000>; > + full-duplex; > + }; > + }; > > - spi1: spi@f8008000 { > - pinctrl-0 = <&pinctrl_spi_ksz>; > - cs-gpios = <&pioC 25 0>; > - id = <1>; > - status = "okay"; > + spi1: spi@f8008000 { > + cs-gpios = <&pioC 25 0>; > + id = <1>; > + status = "okay"; > > - ksz9477: ksz9477@0 { > - compatible = "microchip,ksz9477"; > - reg = <0>; > + ksz9477: ksz9477@0 { > + compatible = "microchip,ksz9477"; > + reg = <0>; > > - spi-max-frequency = <44000000>; > - spi-cpha; > - spi-cpol; > + spi-max-frequency = <44000000>; > + spi-cpha; > + spi-cpol; > + > + status = "okay"; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + label = "lan1"; > + }; > + port@1 { > + reg = <1>; > + label = "lan2"; > + }; > + port@2 { > + reg = <2>; > + label = "lan3"; > + }; > + port@3 { > + reg = <3>; > + label = "lan4"; > + }; > + port@4 { > + reg = <4>; > + label = "lan5"; > + }; > + port@5 { > + reg = <5>; > + label = "cpu"; > + ethernet = <ð0>; > + fixed-link { > + speed = <1000>; > + full-duplex; > + }; > + }; > + }; > + }; > + }; > > - status = "okay"; > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - port@0 { > - reg = <0>; > - label = "lan1"; > - }; > - port@1 { > - reg = <1>; > - label = "lan2"; > - }; > - port@2 { > - reg = <2>; > - label = "lan3"; > - }; > - port@3 { > - reg = <3>; > - label = "lan4"; > - }; > - port@4 { > - reg = <4>; > - label = "lan5"; > - }; > - port@5 { > - reg = <5>; > - label = "cpu"; > - ethernet = <ð0>; > - fixed-link { > - speed = <1000>; > - full-duplex; > - }; > - }; > - }; > - }; > - }; This part however is a nice cleanup. You can submit this patch as a separate patch, once netdev has opened again in about 10 days time. Andrew