Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbdIHBMr (ORCPT ); Thu, 7 Sep 2017 21:12:47 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:60327 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdIHBMq (ORCPT ); Thu, 7 Sep 2017 21:12:46 -0400 Date: Fri, 8 Sep 2017 03:12:43 +0200 From: Andrew Lunn To: Tristram.Ha@microchip.com Cc: muvarov@gmail.com, pavel@ucw.cz, nathan.leigh.conrad@gmail.com, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Woojung.Huh@microchip.com Subject: Re: [PATCH RFC 3/6] The file ksz_common.c contains common code shared by all KSZ switch drivers Message-ID: <20170908011243.GC2746@lunn.ch> References: <93AF473E2DA327428DE3D46B72B1E9FD411218DC@CHN-SV-EXMX02.mchp-main.com> <93AF473E2DA327428DE3D46B72B1E9FD41121A0D@CHN-SV-EXMX02.mchp-main.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <93AF473E2DA327428DE3D46B72B1E9FD41121A0D@CHN-SV-EXMX02.mchp-main.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 548 Lines: 19 Hi Tristram You patches are so badly mangled that they won't apply. So i'm guessing a bit here... What i think is you can do this in three patches: 1) Straight rename of ksz_common.c to ksz9477.c. Makefile changes to fit, no code changes. 2) Move common code back into ksz_common.c. Makefile changes to fit. 3) ksz9477.c prefix name changes It looks like there is not too much common code in ksz_common.c. So doing it this way makes the changes minimal, and things compile at each stage. Remember to use -M with git format-patch. Andrew