Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753469AbdIHC3i (ORCPT ); Thu, 7 Sep 2017 22:29:38 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:33732 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbdIHC3g (ORCPT ); Thu, 7 Sep 2017 22:29:36 -0400 X-Google-Smtp-Source: ADKCNb5QqcuKdbuZWalPHKghw5kH8avFHIp6ROtW6/Jzk55CQVeHMvZpxMU7kW9DZIDhkGKI5uJBYQ== Date: Fri, 8 Sep 2017 11:31:17 +0900 From: AKASHI Takahiro To: Dave Young Cc: catalin.marinas@arm.com, will.deacon@arm.com, bauerman@linux.vnet.ibm.com, dhowells@redhat.com, vgoyal@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, akpm@linux-foundation.org, mpe@ellerman.id.au, bhe@redhat.com, arnd@arndb.de, ard.biesheuvel@linaro.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/14] kexec_file: factor out crashdump elf header function from x86 Message-ID: <20170908023115.GA17186@linaro.org> Mail-Followup-To: AKASHI Takahiro , Dave Young , catalin.marinas@arm.com, will.deacon@arm.com, bauerman@linux.vnet.ibm.com, dhowells@redhat.com, vgoyal@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, akpm@linux-foundation.org, mpe@ellerman.id.au, bhe@redhat.com, arnd@arndb.de, ard.biesheuvel@linaro.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20170824081811.19299-1-takahiro.akashi@linaro.org> <20170824081811.19299-6-takahiro.akashi@linaro.org> <20170825054749.GA8604@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170825054749.GA8604@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 721 Lines: 22 On Fri, Aug 25, 2017 at 01:47:49PM +0800, Dave Young wrote: > On 08/24/17 at 05:18pm, AKASHI Takahiro wrote: > > prepare_elf_headers() can also be useful for other architectures, > > including arm64. So let it factored out. > > > > Signed-off-by: AKASHI Takahiro > > Cc: Dave Young > > Cc: Vivek Goyal > > Cc: Baoquan He > > --- > > arch/x86/kernel/crash.c | 324 ---------------------------------------------- > > include/linux/kexec.h | 19 +++ > > kernel/crash_core.c | 333 ++++++++++++++++++++++++++++++++++++++++++++++++ > > It looks better to add these to kexec_file.c instead. Sure -Takahiro AKASHI > Thanks > Dave