Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753796AbdIHCsb (ORCPT ); Thu, 7 Sep 2017 22:48:31 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:41013 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752157AbdIHCs2 (ORCPT ); Thu, 7 Sep 2017 22:48:28 -0400 X-AuditID: b6c32a45-f79466d000002ac6-8e-59b204f9befa Subject: Re: [PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible. To: Marek Szyprowski , inki.dae@samsung.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Hoegeun Kwon From: Hoegeun Kwon Message-id: <56587be3-a08e-f9a0-6d55-287ed3e1aad9@samsung.com> Date: Fri, 08 Sep 2017 11:48:30 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset="utf-8"; format="flowed" Content-transfer-encoding: 7bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGJsWRmVeSWpSXmKPExsWy7bCmhe5Plk2RBi9em1v0njvJZPF+WQ+j xfwj51gtrnx9z2bxfnkXm8Wk+xNYLPofv2a2OH9+A7vFpsfXWC0u75rDZjHj/D4mi7VH7rJb LL1+kcmide8RdouXH0+wOPB7rJm3htFj06pONo/t3x6wetzvPs7ksXlJvUffllWMHp83yQWw R6XaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gDdraRQ lphTChQKSCwuVtK3synKLy1JVcjILy6xVYo2NDTSMzQw1zMyMtIzMY61MjIFKklIzTg2fyFj wR6Zig9nvrA2MC4V6WLk5JAQMJH4ea6fFcIWk7hwbz1bFyMXh5DADkaJrr2LWEASQgLfGSV2 7guAaViyZAk7RHwDo8SfSaEQDXcZJY6dXsUIkhAW8JbYMmkTE0hCROAao8S+nivsIA6zwGVG iYn3+plAqtgEdCW+9lwHs3kF7CSu3v4NdgeLgKrEnds7wFaICkRIbPs+gw2iRlDix+R7YCdx CthL9Dw5ChZnFrCSePavlRXClpfYvOYtM4QtLtHcepMFZLGEwDx2iZ9PXjNC/OAi0XvvGhuE LSzx6vgWdghbWuLZqo1QNfUSl3ecZIRobmCU6J84G6rIWOJUVyMTxAY+iY7Df4HiHEBxXomO NiGIEg+Jab8uMEHYjhLPHu1gg4TXBCaJySu1JjDKz0LyzywkP8xC8sMsJD8sYGRZxSiWWlCc m55abFRgqFecmFtcmpeul5yfu4kRnIa1XHcwzjjnc4hRgINRiYd3QujGSCHWxLLiytxDjBIc zEoivIXMmyKFeFMSK6tSi/Lji0pzUosPMZoCw3sis5Rocj4wR+SVxBuaWBqYmJkZmZtZAJOe OG/9tmsRQgLpiSWp2ampBalFMH1MHJxSDYzr3y3TrJx+SjLpJk/K41kvCj9Nirr436xXXPfN dLmjy1pDzhhFC95uONdsqKa6kiExI6iwu+3bytwzh1sMmHv3syW9rjj1pela5qVrU9OsXsZG zuB+l18tuY5rh+lk/xJZPaUvVwQuth15v7V6xpc5B/YZvs1/sdBB/Xz6sYNr1jy2jNtz8NI3 JZbijERDLeai4kQAUFBKvtkDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsVy+t9jQd2fLJsiDRZ8VLPoPXeSyeL9sh5G i/lHzrFaXPn6ns3i/fIuNotJ9yewWPQ/fs1scf78BnaLTY+vsVpc3jWHzWLG+X1MFmuP3GW3 WHr9IpNF694j7BYvP55gceD3WDNvDaPHplWdbB7bvz1g9bjffZzJY/OSeo++LasYPT5vkgtg j+KySUnNySxLLdK3S+DKODZ/IWPBHpmKD2e+sDYwLhXpYuTkkBAwkViyZAl7FyMXh5DAOkaJ ew3vGCGc+4wSKx5sYQGpEhbwltgyaRMTSEJE4BqjxI05d8FamAUuM0qs6vkB1TKBSaLnxgxW kBY2AV2Jrz3XmUBsXgE7iau3f4PFWQRUJe7c3sEOYosKREj0vb3MDlEjKPFj8j2wdZwC9hI9 T46ygdjMAmYSX14eZoWw5SU2r3nLDGGLSzS33mSZwCgwC0n7LCQts5C0zELSsoCRZRWjZGpB cW56brFRgVFearlecWJucWleul5yfu4mRmC8bTus1b+D8fGS+EOMAhyMSjy8FsEbI4VYE8uK K3MPMUpwMCuJ8BYyb4oU4k1JrKxKLcqPLyrNSS0+xCjNwaIkzpvZNyNSSCA9sSQ1OzW1ILUI JsvEwSnVwDhrbvechTkLpsrc1IvrrvPLYrVZerCxweHS+nhPUYspWza8VtXde8L+1W2rCXrC yevuzzmz12VZZIGhyStGYcmNZz2P2sx+dXB3nWni7l3C7wp8N3t/K+nS03o0y7PrqerGfdc+ LWt/9TFj4tJEnvP75p/t9LdMXBfNU9i9VPHYNyN7v1eH9/1UYinOSDTUYi4qTgQAFYb5W7MC AAA= X-CMS-MailID: 20170908024825epcas2p3f55c0ad6f21b9546709be573b9118f78 X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?6raM7ZqM6re8G1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?SG9lZ2V1biBLd29uG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170907093912epcas2p2c012de3af3915a58d889c2d48e283705 X-RootMTR: 20170907093912epcas2p2c012de3af3915a58d889c2d48e283705 References: <1504777143-29834-1-git-send-email-hoegeun.kwon@samsung.com> <1504777143-29834-3-git-send-email-hoegeun.kwon@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3543 Lines: 99 On 09/07/2017 08:27 PM, Marek Szyprowski wrote: > Hi Hoegeun, > > On 2017-09-07 11:39, Hoegeun Kwon wrote: >> Exynos 5250 and 5420 have different hardware rotation limits. However, >> currently it uses only one compatible - "exynos5-gsc". Since we have >> to distinguish between these two, we add different compatible. >> >> Signed-off-by: Hoegeun Kwon > > The new values (5250/5420 specific) should replace old exynos5-gsc, > there is no > point providing both in dts. > Hi Marek, Thanks for your review. I used both compatibles to not modify v4l2. But v4l2 will also be fixed, so 'exynos5-gsc' will be removed. And also, Thanks for your comment for of_device_get_match_data() of patch(3/3). Best regards, Hoegeun >> --- >> arch/arm/boot/dts/exynos5250.dtsi | 8 ++++---- >> arch/arm/boot/dts/exynos5420.dtsi | 4 ++-- >> 2 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi >> b/arch/arm/boot/dts/exynos5250.dtsi >> index 8dbeb87..f795c76 100644 >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> @@ -637,7 +637,7 @@ >> }; >> gsc_0: gsc@13e00000 { >> - compatible = "samsung,exynos5-gsc"; >> + compatible = "samsung,exynos5-gsc", >> samsung,exynos5250-gsc"; >> reg = <0x13e00000 0x1000>; >> interrupts = ; >> power-domains = <&pd_gsc>; >> @@ -647,7 +647,7 @@ >> }; >> gsc_1: gsc@13e10000 { >> - compatible = "samsung,exynos5-gsc"; >> + compatible = "samsung,exynos5-gsc", >> samsung,exynos5250-gsc"; >> reg = <0x13e10000 0x1000>; >> interrupts = ; >> power-domains = <&pd_gsc>; >> @@ -657,7 +657,7 @@ >> }; >> gsc_2: gsc@13e20000 { >> - compatible = "samsung,exynos5-gsc"; >> + compatible = "samsung,exynos5-gsc", >> samsung,exynos5250-gsc"; >> reg = <0x13e20000 0x1000>; >> interrupts = ; >> power-domains = <&pd_gsc>; >> @@ -667,7 +667,7 @@ >> }; >> gsc_3: gsc@13e30000 { >> - compatible = "samsung,exynos5-gsc"; >> + compatible = "samsung,exynos5-gsc", >> samsung,exynos5250-gsc"; >> reg = <0x13e30000 0x1000>; >> interrupts = ; >> power-domains = <&pd_gsc>; >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi >> b/arch/arm/boot/dts/exynos5420.dtsi >> index 02d2f89..86afe77 100644 >> --- a/arch/arm/boot/dts/exynos5420.dtsi >> +++ b/arch/arm/boot/dts/exynos5420.dtsi >> @@ -658,7 +658,7 @@ >> }; >> gsc_0: video-scaler@13e00000 { >> - compatible = "samsung,exynos5-gsc"; >> + compatible = "samsung,exynos5-gsc", >> "samsung,exynos5420-gsc"; >> reg = <0x13e00000 0x1000>; >> interrupts = ; >> clocks = <&clock CLK_GSCL0>; >> @@ -668,7 +668,7 @@ >> }; >> gsc_1: video-scaler@13e10000 { >> - compatible = "samsung,exynos5-gsc"; >> + compatible = "samsung,exynos5-gsc", >> "samsung,exynos5420-gsc"; >> reg = <0x13e10000 0x1000>; >> interrupts = ; >> clocks = <&clock CLK_GSCL1>; > > Best regards