Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753930AbdIHDgE (ORCPT ); Thu, 7 Sep 2017 23:36:04 -0400 Received: from mail-it0-f51.google.com ([209.85.214.51]:44622 "EHLO mail-it0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752965AbdIHDgC (ORCPT ); Thu, 7 Sep 2017 23:36:02 -0400 X-Google-Smtp-Source: AOwi7QATM/h2SlT5mdoZ+/V8VX17nMErgGeiWNGN44++jKqwff9HBtkYx5go5rDQsmyowh6+jIBI+zFb68cx7tHS8Vg= MIME-Version: 1.0 In-Reply-To: <20170908031906.izqthq6q7qzbry3p@ubuntu-hedt> References: <20170907233246.GA115838@beast> <20170908031906.izqthq6q7qzbry3p@ubuntu-hedt> From: Kees Cook Date: Thu, 7 Sep 2017 20:36:00 -0700 X-Google-Sender-Auth: vP6BiqAypaYdNs9WhAg4QzLIFFc Message-ID: Subject: Re: [PATCH] selftests/seccomp: Support glibc 2.26 siginfo_t.h To: Seth Forshee , Shuah Khan Cc: Andy Lutomirski , Will Drewry , "open list:KERNEL SELFTEST FRAMEWORK" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1224 Lines: 35 On Thu, Sep 7, 2017 at 8:19 PM, Seth Forshee wrote: > On Thu, Sep 07, 2017 at 04:32:46PM -0700, Kees Cook wrote: >> The 2.26 release of glibc changed how siginfo_t is defined, and the earlier >> work-around to using the kernel definition are no longer needed. The old >> way needs to stay around for a while, though. >> >> Reported-by: Seth Forshee >> Cc: Andy Lutomirski >> Cc: Will Drewry >> Cc: Shuah Khan >> Cc: linux-kselftest@vger.kernel.org >> Cc: stable@vger.kernel.org >> Signed-off-by: Kees Cook >> --- >> Seth, can you double check this to confirm it works for you too? This builds >> and tests correctly for me on both Ubuntu 17.10 (-proposed) with glibc 2.26 >> and with earlier distros with 2.24, etc. > > It builds and tests correctly for me too, with both glibc 2.26 and 2.24. > > Tested-by: Seth Forshee Awesome, thanks! Shuah, is it possible to land this for v4.14? If it has to wait, that's probably okay, as I've marked it for -stable, so it'll get where it needs to be eventually. :) Thanks! -Kees -- Kees Cook Pixel Security