Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754190AbdIHFxf (ORCPT ); Fri, 8 Sep 2017 01:53:35 -0400 Received: from mail-lf0-f49.google.com ([209.85.215.49]:37695 "EHLO mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752762AbdIHFxe (ORCPT ); Fri, 8 Sep 2017 01:53:34 -0400 X-Google-Smtp-Source: AOwi7QAEvJGdgIQ5vcRpUSlVWzc2+9vrOzhEQfVQQYqOTB03hUwGmSj4g67LMIpUaVXUtlji+xRuMqHv0nm000gyEyM= MIME-Version: 1.0 In-Reply-To: References: <20170901053858.10070-1-andrew@aj.id.au> From: Joel Stanley Date: Fri, 8 Sep 2017 15:23:11 +0930 X-Google-Sender-Auth: fX6ZxQ310f9mVfFOvzF13vPf8Xo Message-ID: Subject: Re: [PATCH v2] leds: pca955x: Don't invert requested value in pca955x_gpio_set_value() To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Cc: Andrew Jeffery , linux-leds@vger.kernel.org, OpenBMC Maillist , Linux Kernel Mailing List , rpurdie@rpsys.net, jacek.anaszewski@gmail.com, pavel@ucw.cz, Brandon Wyman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v885rvUK006568 Content-Length: 481 Lines: 18 On Sat, Sep 2, 2017 at 2:36 AM, Cédric Le Goater wrote: > On 09/01/2017 07:38 AM, Andrew Jeffery wrote: >> Rework leds-pca955x so that we avoid the incorrect inversion and clarify >> the semantics with respect to GPIO. >> >> Signed-off-by: Andrew Jeffery > > Reviewed-by: Cédric Le Goater I gave this a spin on our 'witherspoon' system and the LEDs responded as expected. Tested-by: Joel Stanley Cheers, Joel