Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755233AbdIHHhL (ORCPT ); Fri, 8 Sep 2017 03:37:11 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34663 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754655AbdIHHhJ (ORCPT ); Fri, 8 Sep 2017 03:37:09 -0400 X-Google-Smtp-Source: ADKCNb4BSK6VnfnP6iqng5iPgrklQ/f9L0fJYn+pDdsUhkk662S/uuxTGs0rmm5LL8Yvn/J3iAygHg== Date: Fri, 8 Sep 2017 09:36:57 +0200 From: Corentin Labbe To: Maxime Ripard Cc: robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes Message-ID: <20170908073657.GA29999@Red> References: <20170908071156.5115-1-clabbe.montjoie@gmail.com> <20170908071156.5115-2-clabbe.montjoie@gmail.com> <20170908071954.j2bhtw4wqa27fald@flea.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170908071954.j2bhtw4wqa27fald@flea.lan> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1239 Lines: 42 On Fri, Sep 08, 2017 at 09:19:54AM +0200, Maxime Ripard wrote: > On Fri, Sep 08, 2017 at 09:11:47AM +0200, Corentin Labbe wrote: > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts > > index 1c2387bd5df6..968908761194 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts > > @@ -50,6 +50,7 @@ > > compatible = "friendlyarm,nanopi-neo2", "allwinner,sun50i-h5"; > > > > aliases { > > + ethernet0 = &emac; > > serial0 = &uart0; > > }; > > > > @@ -108,6 +109,22 @@ > > status = "okay"; > > }; > > > > +&emac { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&emac_rgmii_pins>; > > + phy-supply = <®_gmac_3v3>; > > + phy-handle = <&ext_rgmii_phy>; > > + phy-mode = "rgmii"; > > + status = "okay"; > > +}; > > + > > +&mdio { > > + ext_rgmii_phy: ethernet-phy@7 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <7>; > > + }; > > +}; > > + > > This won't compile, you don't have that node in the H5 DTSI. > Since H5 DTSI include arm/sunxi-h3-h5.dtsi it compiles. Furthermore, I restested just now and confirm, it compiles fine. Regards