Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932572AbdIHIdw (ORCPT ); Fri, 8 Sep 2017 04:33:52 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:46129 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754328AbdIHIdt (ORCPT ); Fri, 8 Sep 2017 04:33:49 -0400 X-Google-Smtp-Source: AOwi7QDPLPk2gtnZWbG5rnqZw9P+tsppYdvbuoEpE7vBH5GErQx/FTzH6ufrqzE9U8Qm/11oDKHALQ== Subject: Re: [PATCH 1/4] sched/sched.h: remove duplicate prototype of __dl_clear_params() To: luca abeni , linux-kernel@vger.kernel.org Cc: Peter Zijlstra , Ingo Molnar , Juri Lelli , Steven Rostedt , Mathieu Poirier References: <1504778971-13573-1-git-send-email-luca.abeni@santannapisa.it> <1504778971-13573-2-git-send-email-luca.abeni@santannapisa.it> From: Daniel Bristot de Oliveira Message-ID: <3f4582ad-d3ee-7094-ba31-bdaf0c1ee9e4@redhat.com> Date: Fri, 8 Sep 2017 10:33:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1504778971-13573-2-git-send-email-luca.abeni@santannapisa.it> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 32 Hi, I wonder if a commit log, even an one line comment, explaining that this function was already declared in the file could help to understand this patch... But, the patch is so trivial... that... not sure it is worth... anyway... On 09/07/2017 12:09 PM, luca abeni wrote: > Signed-off-by: luca abeni Reviewed-by: Daniel Bristot de Oliveira -- Daniel > --- > kernel/sched/sched.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h > index 1043c8b..0b93e4b 100644 > --- a/kernel/sched/sched.h > +++ b/kernel/sched/sched.h > @@ -255,7 +255,6 @@ extern int sched_dl_overflow(struct task_struct *p, int policy, > extern void __setparam_dl(struct task_struct *p, const struct sched_attr *attr); > extern void __getparam_dl(struct task_struct *p, struct sched_attr *attr); > extern bool __checkparam_dl(const struct sched_attr *attr); > -extern void __dl_clear_params(struct task_struct *p); > extern bool dl_param_changed(struct task_struct *p, const struct sched_attr *attr); > extern int dl_task_can_attach(struct task_struct *p, > const struct cpumask *cs_cpus_allowed); >