Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756295AbdIHIqz (ORCPT ); Fri, 8 Sep 2017 04:46:55 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:45872 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756277AbdIHIqw (ORCPT ); Fri, 8 Sep 2017 04:46:52 -0400 X-IronPort-AV: E=Sophos;i="5.42,360,1500933600"; d="scan'208";a="290131046" Date: Fri, 8 Sep 2017 10:46:21 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: harsha cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] staging: rt8712: xmit_linux: Avoid multiple assignments in a single line In-Reply-To: <1504859870-13153-1-git-send-email-harshasharmaiitr@gmail.com> Message-ID: References: <1504859870-13153-1-git-send-email-harshasharmaiitr@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1535 Lines: 43 On Fri, 8 Sep 2017, harsha wrote: > Fixed coding style issue > > Signed-off-by: Harsha Sharma > --- > drivers/staging/rtl8712/xmit_linux.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c > index d13fd15..03c6b0c 100644 > --- a/drivers/staging/rtl8712/xmit_linux.c > +++ b/drivers/staging/rtl8712/xmit_linux.c > @@ -49,8 +49,10 @@ static uint remainder_len(struct pkt_file *pfile) > void _r8712_open_pktfile(_pkt *pktptr, struct pkt_file *pfile) > { > pfile->pkt = pktptr; > - pfile->cur_addr = pfile->buf_start = pktptr->data; > - pfile->pkt_len = pfile->buf_len = pktptr->len; I think this may be considered to be more readable as is. julia > + pfile->cur_addr = pktptr->data; > + pfile->buf_start = pfile->cur_addr; > + pfile->pkt_len = pktptr->len; > + pfile->buf_len = pfile->pkt_len; > pfile->cur_buffer = pfile->buf_start; > } > > -- > 1.9.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504859870-13153-1-git-send-email-harshasharmaiitr%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >