Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754716AbdIHJvP (ORCPT ); Fri, 8 Sep 2017 05:51:15 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:45631 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754576AbdIHJvC (ORCPT ); Fri, 8 Sep 2017 05:51:02 -0400 Date: Fri, 8 Sep 2017 12:50:39 +0300 From: Dan Carpenter To: Julia Lawall Cc: harsha , devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors Message-ID: <20170908095039.ns6kjwa2j5jbrrbi@mwanda> References: <1504863598-16301-1-git-send-email-harshasharmaiitr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 928 Lines: 28 On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote: > > > On Fri, 8 Sep 2017, harsha wrote: > > > From: Harsha Sharma > > > > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled > > > > Signed-off-by: Harsha Sharma > > --- > > Changes in v4: > > -Correct the format of the subject. > > -Signed-off properly. > > It's not signed off properly. Like Greg just said (maybe the mails > crossed), the sign off needs to be the same as the From line. This > probably relates to your git configuration or your mailer. Send the patch > to yourself before sending it out on the mailing list to be sure that > everything is ok. > This is actually OK-ish... It's better when we don't have the extra From: and there is no need for that with gmail, but we sometimes allow it for companies which have broken mailservers. regards, dan carpenter