Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755994AbdIHNQl (ORCPT ); Fri, 8 Sep 2017 09:16:41 -0400 Received: from mail.kdab.com ([176.9.126.58]:57498 "EHLO mail.kdab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755013AbdIHNQk (ORCPT ); Fri, 8 Sep 2017 09:16:40 -0400 From: Milian Wolff To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , Ingo Molnar , Namhyung Kim , David Ahern , Peter Zijlstra Subject: Re: [PATCH 1/4] perf ui progress: Make sure we always define step value Date: Fri, 08 Sep 2017 15:16:37 +0200 Message-ID: <8050280.N0YfCng2Hd@agathebauer> Organization: KDAB (Deutschland) GmbH&Co KG, a KDAB Group company In-Reply-To: <20170908120510.22515-2-jolsa@kernel.org> References: <20170908120510.22515-1-jolsa@kernel.org> <20170908120510.22515-2-jolsa@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1267 Lines: 37 On Freitag, 8. September 2017 14:05:07 CEST Jiri Olsa wrote: > Unlikely, but we could have ui_progress__init being called > with total < 16, which would set the next and step variables > to 0. That would force unnecessary ui_progress__ops->update > calls because 'next' would never raise. > > Forcing the next and step values to be always > 0. > > Link: http://lkml.kernel.org/n/tip-0zcvhmsmbhkfgoi7c670rq2x@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/ui/progress.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/ui/progress.c b/tools/perf/ui/progress.c > index a0f24c7115c5..a9c15804b1f6 100644 > --- a/tools/perf/ui/progress.c > +++ b/tools/perf/ui/progress.c > @@ -25,7 +25,7 @@ void ui_progress__update(struct ui_progress *p, u64 adv) > void ui_progress__init(struct ui_progress *p, u64 total, const char *title) > { > p->curr = 0; > - p->next = p->step = total / 16; > + p->next = p->step = total / 16 ?: 1; > p->total = total; > p->title = title; This is a GNU extension, does this compile with clang? Cheers -- Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH&Co KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts