Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756498AbdIHN1J (ORCPT ); Fri, 8 Sep 2017 09:27:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:34766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756486AbdIHN0p (ORCPT ); Fri, 8 Sep 2017 09:26:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D1C321B67 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Fri, 8 Sep 2017 10:26:42 -0300 From: Arnaldo Carvalho de Melo To: Milian Wolff Cc: Jiri Olsa , lkml , Ingo Molnar , Namhyung Kim , David Ahern , Peter Zijlstra Subject: Re: [PATCH 1/4] perf ui progress: Make sure we always define step value Message-ID: <20170908132642.GA26336@kernel.org> References: <20170908120510.22515-1-jolsa@kernel.org> <20170908120510.22515-2-jolsa@kernel.org> <8050280.N0YfCng2Hd@agathebauer> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8050280.N0YfCng2Hd@agathebauer> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2628 Lines: 59 Em Fri, Sep 08, 2017 at 03:16:37PM +0200, Milian Wolff escreveu: > On Freitag, 8. September 2017 14:05:07 CEST Jiri Olsa wrote: > > +++ b/tools/perf/ui/progress.c > > @@ -25,7 +25,7 @@ void ui_progress__update(struct ui_progress *p, u64 adv) > > void ui_progress__init(struct ui_progress *p, u64 total, const char *title) > > { > > p->curr = 0; > > - p->next = p->step = total / 16; > > + p->next = p->step = total / 16 ?: 1; > > p->total = total; > > p->title = title; > > This is a GNU extension, does this compile with clang? Huh? [acme@jouet linux]$ find tools/ -name "*.[ch]"| xargs grep ?: | wc -l 64 [acme@jouet linux]$ find . -name "*.[ch]"| xargs grep ?: | wc -l 725 [acme@jouet linux]$ And yes, tools/perf/ is built with clang regularly, I use containers to test build the tools/{perf,lib} codebase with gcc and clang on almost all distros, things like: [acme@jouet linux]$ cat ~/git/linux-perf-tools-build/fedora/26/Dockerfile # docker.io/acmel/linux-perf-tools-build-fedora:26 FROM docker.io/fedora:26 MAINTAINER Arnaldo Carvalho de Melo # The second dnf line is to be able to build a kernel, do a make header_install, etc, # So that we can build samples/bpf/ and the kernel RUN dnf -y install make gcc flex bison elfutils-libelf-devel \ bc findutils clang llvm openssl git \ elfutils-devel libunwind-devel audit-libs-devel \ openssl-devel slang-devel gtk2-devel perl-ExtUtils-Embed \ python-devel binutils-devel xz-devel numactl-devel systemtap-sdt-devel \ redhat-rpm-config && \ dnf -y clean all && \ rm -rf /usr/share/doc /usr/share/gtk-doc /usr/share/locale /usr/share/man && \ mkdir -m 777 -p /tmp/build/perf /tmp/build/objtool /tmp/build/linux && \ groupadd -r perfbuilder && \ useradd -m -r -g perfbuilder perfbuilder && \ chown -R perfbuilder.perfbuilder /tmp/build USER perfbuilder ENTRYPOINT make -C /git/linux/tools/perf O=/tmp/build/perf && \ rm -rf /tmp/build/perf/{.[^.]*,*} && \ make -C /git/linux/tools/perf O=/tmp/build/perf CC=clang && \ rm -rf /tmp/build/perf/{.[^.]*,*} && \ make NO_LIBELF=1 -C /git/linux/tools/perf O=/tmp/build/perf && \ rm -rf /tmp/build/perf/{.[^.]*,*} && \ make NO_LIBELF=1 -C /git/linux/tools/perf O=/tmp/build/perf CC=clang && \ make -C /git/linux/tools/objtool O=/tmp/build/objtool && \ make -C /git/linux O=/tmp/build/linux defconfig && \ make -C /git/linux O=/tmp/build/linux headers_install && \ make -C /git/linux O=/tmp/build/linux samples/bpf/ [acme@jouet linux]$ - Arnaldo