Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756522AbdIHNpq (ORCPT ); Fri, 8 Sep 2017 09:45:46 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33199 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756351AbdIHNpn (ORCPT ); Fri, 8 Sep 2017 09:45:43 -0400 X-Google-Smtp-Source: ADKCNb7r/oYIaSoSecI/vL6oXIJL9+msiqgApZMm0k0JbcdD/HSMT38NAWrwlAfKOOkbL1UAiJ6j8vNH3QJRwZSAo50= MIME-Version: 1.0 In-Reply-To: <20170908131704.32517-1-colin.king@canonical.com> References: <20170908131704.32517-1-colin.king@canonical.com> From: Emil Velikov Date: Fri, 8 Sep 2017 14:45:40 +0100 Message-ID: Subject: Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure To: Colin King Cc: Eric Anholt , David Airlie , ML dri-devel , kernel-janitors@vger.kernel.org, "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 28 Hi Colin, On 8 September 2017 at 14:17, Colin King wrote: > From: Colin Ian King > > The current error handling on devm_kzalloc failures performs a non-null > check on connector. Thss check is redundant because connector is null > at that failure point. With this check removed, we may as well make > the failure path into a trivial -ENOMEM return to clean up the error > handling. > > Detected by CoverityScan CID#1339527 ("Logically dead code") > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index 937da8dd65b8..a8808c1a1e03 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -311,14 +311,11 @@ static struct drm_connector *vc4_hdmi_connector_init(struct drm_device *dev, > { > struct drm_connector *connector = NULL; I think you can drop the initializer now. -Emil