Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932068AbdIHOjG (ORCPT ); Fri, 8 Sep 2017 10:39:06 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:26154 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756303AbdIHOjF (ORCPT ); Fri, 8 Sep 2017 10:39:05 -0400 Date: Fri, 8 Sep 2017 17:38:34 +0300 From: Dan Carpenter To: Srishti Sharma Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON(). Message-ID: <20170908143833.yisoj3t2yp5httle@mwanda> References: <1504879698-5855-1-git-send-email-srishtishar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504879698-5855-1-git-send-email-srishtishar@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 24 On Fri, Sep 08, 2017 at 07:38:18PM +0530, Srishti Sharma wrote: > Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel. > > Signed-off-by: Srishti Sharma > --- > drivers/staging/media/omap4iss/iss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c > index c26c99fd..b1036ba 100644 > --- a/drivers/staging/media/omap4iss/iss.c > +++ b/drivers/staging/media/omap4iss/iss.c > @@ -893,7 +893,7 @@ void omap4iss_put(struct iss_device *iss) > return; > > mutex_lock(&iss->iss_mutex); > - BUG_ON(iss->ref_count == 0); > + WARN_ON(iss->ref_count == 0); ref_counting bugs often have a security aspect. BUG_ON() is probably safer here. Better to crash than to lose all your bitcoin. regards, dan carpenter