Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756320AbdIHOkj (ORCPT ); Fri, 8 Sep 2017 10:40:39 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:34458 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755916AbdIHOkf (ORCPT ); Fri, 8 Sep 2017 10:40:35 -0400 X-Google-Smtp-Source: AOwi7QCcYfYzVPzuJ15as9TM5lNI0qLKaOF/lT17W0HXGQbPOkcHv0zn5joOCaA/RcKp7HyFBq7LmQ== Date: Fri, 8 Sep 2017 07:40:32 -0700 From: Tejun Heo To: Shaohua Li Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, lizefan@huawei.com, tglx@linutronix.de, kernel-team@fb.com, axboe@kernel.dk, Shaohua Li Subject: Re: [PATCH 1/3] kthread: add a mechanism to store cgroup info Message-ID: <20170908144032.GY1774378@devbig577.frc2.facebook.com> References: <9d25e5bed5ef2fad5f8a817e293f0d93e3b329c2.1504748195.git.shli@fb.com> <20170908143537.GW1774378@devbig577.frc2.facebook.com> <20170908143846.GX1774378@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170908143846.GX1774378@devbig577.frc2.facebook.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 632 Lines: 17 On Fri, Sep 08, 2017 at 07:38:46AM -0700, Tejun Heo wrote: > On Fri, Sep 08, 2017 at 07:35:37AM -0700, Tejun Heo wrote: > > * It's a bit weird to associate a kthread with a css without being > > specific. If what's needed is a generic association (this kthread > > is temporarily servicing this cgroup), it should be associated with > > the cgroup. But, I think it'd be better to make it specific instead > > - ie. kthread_set_io_css(). > > kthread[_set]_blkcg_css() probably is a more consistent name. Sorry, I meant kthread[_associate]_blkcg() so that it's consistent with bio[_associate]_blkcg(). Thanks. -- tejun