Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756346AbdIHOpA (ORCPT ); Fri, 8 Sep 2017 10:45:00 -0400 Received: from conssluserg-04.nifty.com ([210.131.2.83]:52067 "EHLO conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755215AbdIHOo7 (ORCPT ); Fri, 8 Sep 2017 10:44:59 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com v88Eis63020467 X-Nifty-SrcIP: [209.85.161.178] X-Google-Smtp-Source: ADKCNb41OFAN8MVkiSiIhl1UiJ9UWhWTqcU2Kz+ReVD0ynigzap+y9DEyS0WnwyJkGGHbhhA59snTH3/1sUgivxVSJw= MIME-Version: 1.0 In-Reply-To: <1504875731-3680-3-git-send-email-hayashi.kunihiko@socionext.com> References: <1504875731-3680-1-git-send-email-hayashi.kunihiko@socionext.com> <1504875731-3680-3-git-send-email-hayashi.kunihiko@socionext.com> From: Masahiro Yamada Date: Fri, 8 Sep 2017 23:44:13 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver To: Kunihiko Hayashi Cc: netdev@vger.kernel.org, "David S. Miller" , Andrew Lunn , Florian Fainelli , Rob Herring , Mark Rutland , linux-arm-kernel , Linux Kernel Mailing List , devicetree@vger.kernel.org, Masami Hiramatsu , Jassi Brar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2171 Lines: 78 2017-09-08 22:02 GMT+09:00 Kunihiko Hayashi : > diff --git a/drivers/net/ethernet/socionext/Kconfig b/drivers/net/ethernet/socionext/Kconfig > new file mode 100644 > index 0000000..788f26f > --- /dev/null > +++ b/drivers/net/ethernet/socionext/Kconfig > @@ -0,0 +1,22 @@ > +config NET_VENDOR_SOCIONEXT > + bool "Socionext ethernet drivers" > + default y > + ---help--- > + Option to select ethernet drivers for Socionext platforms. > + > + Note that the answer to this question doesn't directly affect the > + kernel: saying N will just cause the configurator to skip all > + the questions about Agere devices. If you say Y, you will be asked > + for your specific card in the following questions. Agere? > + > + dev_info(dev, "Socionext %c%c%c%c Ethernet IP %s (irq=%d, phy=%s)\n", > + (ave_id >> 24) & 0xff, (ave_id >> 16) & 0xff, > + (ave_id >> 8) & 0xff, (ave_id >> 0) & 0xff, > + buf, ndev->irq, phy_modes(phy_mode)); > + > + return 0; > +err_netdev_register: Maybe, a bad label name. for ex. out_del_napi or whatever. Documentation/process/coding-style.rst says "Choose label names which say what the goto does ..." > + netif_napi_del(&priv->napi_rx); > + netif_napi_del(&priv->napi_tx); > + mdiobus_unregister(priv->mdio); > +err_mdiobus_register: > +err_mdiobus_alloc: > +err_req_irq: These three should be merged, for ex. out_free_device. I ran sparse for you. Please take a look if it is worthwhile. Seems endianess around mac_addr. drivers/net/ethernet/socionext/sni_ave.c:423:15: warning: cast to restricted __le32 drivers/net/ethernet/socionext/sni_ave.c:425:20: warning: cast to restricted __le16 drivers/net/ethernet/socionext/sni_ave.c:1194:15: warning: cast to restricted __le32 drivers/net/ethernet/socionext/sni_ave.c:1196:20: warning: cast to restricted __le16 drivers/net/ethernet/socionext/sni_ave.c:1398:15: warning: cast to restricted __le32 drivers/net/ethernet/socionext/sni_ave.c:1400:20: warning: cast to restricted __le16 -- Best Regards Masahiro Yamada