Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756383AbdIHOsP (ORCPT ); Fri, 8 Sep 2017 10:48:15 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:36563 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756219AbdIHOsM (ORCPT ); Fri, 8 Sep 2017 10:48:12 -0400 X-Google-Smtp-Source: AOwi7QDzp5Tpk4A5ZbKvcfaWc2ldD/dsQT/FfTw//TRTFB1C6WIjzd5O6Hyi750LEJLFgNERuCkJ5Q== Date: Fri, 8 Sep 2017 07:48:09 -0700 From: Tejun Heo To: Shaohua Li Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, lizefan@huawei.com, tglx@linutronix.de, kernel-team@fb.com, axboe@kernel.dk, Shaohua Li Subject: Re: [PATCH 3/3] block/loop: make loop cgroup aware Message-ID: <20170908144808.GA1774378@devbig577.frc2.facebook.com> References: <83915a4be672d99729029800196008c3b39c7a3a.1504748195.git.shli@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83915a4be672d99729029800196008c3b39c7a3a.1504748195.git.shli@fb.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 24 Hello, On Wed, Sep 06, 2017 at 07:00:53PM -0700, Shaohua Li wrote: > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index 9d4545f..9850b27 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -482,6 +482,8 @@ static void lo_rw_aio_complete(struct kiocb *iocb, long ret, long ret2) > { > struct loop_cmd *cmd = container_of(iocb, struct loop_cmd, iocb); > > + if (cmd->css) > + css_put(cmd->css); > cmd->ret = ret > 0 ? 0 : ret; > lo_rw_aio_do_completion(cmd); The fact that we're forwarding explicitly in loop still bothers me a bit. Can you please elaborate why we don't want to do this generically through aio? Thanks. -- tejun