Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753878AbdIHPoZ (ORCPT ); Fri, 8 Sep 2017 11:44:25 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:34390 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365AbdIHPoY (ORCPT ); Fri, 8 Sep 2017 11:44:24 -0400 X-Google-Smtp-Source: AOwi7QDgYj+XPvTWtjZZ8D39cyvXg9inz2A4P+YDKzW6qT4ltRxiGAYY0pg3abBJeowlxWNclPsXoF9Q2WYwFPqcLps= MIME-Version: 1.0 In-Reply-To: <20170908075519.GD4957@infradead.org> References: <20170907173609.22696-1-tycho@docker.com> <20170907173609.22696-11-tycho@docker.com> <20170908075519.GD4957@infradead.org> From: Kees Cook Date: Fri, 8 Sep 2017 08:44:22 -0700 X-Google-Sender-Auth: NPyO-IS5ObaGkKdu7hP31elnTDo Message-ID: Subject: Re: [PATCH v6 10/11] mm: add a user_virt_to_phys symbol To: Christoph Hellwig Cc: Tycho Andersen , LKML , Linux-MM , "kernel-hardening@lists.openwall.com" , Marco Benatto , Juerg Haefliger , "linux-arm-kernel@lists.infradead.org" , "x86@kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 558 Lines: 17 On Fri, Sep 8, 2017 at 12:55 AM, Christoph Hellwig wrote: > On Thu, Sep 07, 2017 at 11:36:08AM -0600, Tycho Andersen wrote: >> We need someting like this for testing XPFO. Since it's architecture >> specific, putting it in the test code is slightly awkward, so let's make it >> an arch-specific symbol and export it for use in LKDTM. > > We really should not add an export for this. > > I think you'll want to just open code it in your test module. Isn't that going to be fragile? Why not an export? -Kees -- Kees Cook Pixel Security