Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbdIHQK3 (ORCPT ); Fri, 8 Sep 2017 12:10:29 -0400 Received: from ms.lwn.net ([45.79.88.28]:53606 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbdIHQK2 (ORCPT ); Fri, 8 Sep 2017 12:10:28 -0400 Date: Fri, 8 Sep 2017 10:10:26 -0600 From: Jonathan Corbet To: Mauro Carvalho Chehab Cc: Linux Doc Mailing List , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] Two cleanups for Sphinx conf.py Message-ID: <20170908101026.32969fee@lwn.net> In-Reply-To: References: Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1030 Lines: 27 On Sun, 3 Sep 2017 16:12:44 -0300 Mauro Carvalho Chehab wrote: > Those patches are just cleanups for Documentation/conf.py. > > The first one removes a package usage directive for a LateX package > that it is not used. > > The second one moves some LaTeX preamble code that it is used only > on Sphinx 1.4 and 1.5 to a separate if. On Sphinx 1.6, the macros there > are silently ignored. While the conf.py becomes a little bit more complex, > it clearly marks the backward-compatible code, with IMHO, it is a > good idea, specially as some day, we may drop support for older Sphinx > versions. > > None of those patches are mandatory. Feel free to apply any time you > want (or discard them, if you don't thing it is worth). OK, these are applied (and the adjustbox one too). PDF generation seems to work pretty well at the moment, with one exception: I don't get a table of contents in any of the files (just a blank page saying "Contents"). Are you seeing something different? Thanks, jon